Several Translation issues #19155

Jojo-Schmitz · 2023-08-24T09:56:43Z

Differentiating the meanings of "Minor" and "Major"
Resolves: German translation: “major” should be “groß” or “Dur” depending on context #19153
"notes" to "keys", as this is about the piano keyboard
Sentence case vs. Title Case in transpose dialog
Sentence case vs. Title Case in breaks dialog
Sentence case vs. Title Case in editpitch dialog
Sentence case vs. Title Case in editstaff dialog
Sentence case vs. Title Case in editstafftype dialog
Sentence case vs. Title Case in editstringdata dialog
Sentence case vs. Title Case in keyedit dialog
Sentence case vs. Title Case in masterpalette dialog
Sentence case vs. Title Case in measureproperties dialog
Sentence case vs. Title Case in pagesettings dialog
Sentence case vs. Title Case in realizeharmony dialog
Sentence case vs. Title Case in selectnote dialog
Sentence case vs. Title Case in specialcharacters dialog
Sentence case vs. Title Case in stafftextproperties dialog
Sentence case vs. Title Case in tuplet dialog
Sentence case vs. Title Case in voicingselect dialog
Sentence case vs. Title Case in voicingselect dialog
Sentence case vs. Title Case in editstyle dialog
Sentence case vs. Title Case in editdrumset dialog
Plural for palettes
English plurals rather than Italian ones
Use winged double quotes (as per discussion in Fix: incorrect quotes and apostrophes #17748)
Not sure whether the single quotes should also get changed to winged ones, there are some 140 strings affected, the vast majority of them in the editstyle dialog, which is slated to get converted to QML
Better naming, "Leading" to "Leading space"
"Notehead scheme" in staff properties different from "Notehead system" in Properties panel
Resolves "Notehead scheme" in staff properties different from "Notehead system" in Properties panel #19166

shoogle

I see this in different files:

//: mode of a key signature, not an interval
qsTrc("inspector", "Major")

//: Interval, not the mode of a key signature
qsTrc("inspector", "Major")

However, translation comments are not considered during translation lookup, so both strings will use the same translation for "Major".

To get a different translation, you must either change the context string:

qsTrc("inspector/keysignatures", "Major")

qsTrc("inspector/ornaments", "Major")

Or pass in a disambiguation string as an additional argument to qsTrc():

qsTrc("inspector", "Major", "key signature mode")

qsTrc("inspector", "Major", "interval quality")

I'll let @cbjeukendrup say which he would prefer in this case.

The context and disambiguation are displayed on Transifex, but they are buried quite far down the page, so it is helpful to provide the translation comments as well.

src/notation/view/widgets/transposedialog.ui

Jojo-Schmitz · 2023-08-24T12:21:12Z

@shoogle : For now I've picked the disabiguation method

src/appshell/view/internal/splashscreen/newinstanceloadingscreenview.cpp

...pector/view/qml/MuseScore/Inspector/general/appearance/internal/HorizontalSpacingSection.qml

src/inspector/view/qml/MuseScore/Inspector/notation/sectionbreaks/SectionBreakSettings.qml

src/project/qml/MuseScore/Project/internal/NewScore/KeySignatureSettings.qml

shoogle

Looks good to me, but I'd like to get sign-off from a designer before we merge.

cbjeukendrup · 2023-08-25T09:30:17Z

I still doubt very much about whether we should do that sentence case thing with those old dialogs. It gives translators a lot of useless extra work, and the benefits are very, very small, considering that these dialogs are to be completely overhauled anyway. (And I'm inclined to say that these dialogs are so ugly anyway that some capitalisation inconsistencies that only 0.03% of people will ever notice are not going to make much of a difference.)

Jojo-Schmitz · 2023-08-25T10:15:50Z

It isn't that many strings, some 125

shoogle · 2023-08-25T10:18:55Z

I think the Translation Memory should recognise these strings as being similar to the previous ones and provide the old translation as a suggestion, possibly even fill it in automatically, so all translators have to do is review.

shoogle · 2023-08-25T12:32:51Z

src/engraving/libmscore/jump.cpp

-    { JumpType::DC_AL_DBLCODA,  "D.C. al Double Coda",   "start", "varcoda",  "codab" },
-    { JumpType::DS_AL_DBLCODA,  "D.S. al Double Coda",   "segno", "varcoda",  "codab" },
-    { JumpType::DSS,            "Dal Segno Segno",       "varsegno", "end",  "" },
-    { JumpType::DSS_AL_CODA,    "D.S.S. al Coda",        "varsegno", "coda",  "codab" },
-    { JumpType::DSS_AL_DBLCODA, "D.S.S. al Double Coda", "varsegno", "varcoda", "codab" },
-    { JumpType::DSS_AL_FINE,    "D.S.S. al Fine",        "varsegno", "fine",  "" },
+    { JumpType::DC_AL_DBLCODA,  "D.C. al Codetta",   "start", "varcoda",  "codab" },
+    { JumpType::DS_AL_DBLCODA,  "D.S. al Codetta",   "segno", "varcoda",  "codab" },
+    { JumpType::DSS,            "Dal Segno Segno",   "varsegno", "end",  "" },
+    { JumpType::DSS_AL_CODA,    "D.S.S. al Coda",    "varsegno", "coda",  "codab" },
+    { JumpType::DSS_AL_DBLCODA, "D.S.S. al Codetta", "varsegno", "varcoda", "codab" },
+    { JumpType::DSS_AL_FINE,    "D.S.S. al Fine",    "varsegno", "fine",  "" },


@oktophonie, what do you think of these?

I'm not familiar enough with the arcane mysteries of either double codas nor with Italian to say. The language mixture is certainly a bit odd, but whether these changes are 'correct' I don't know.

I'm not sure either, only thing I am sure about is that the Double Coda was called Codetta in Mu1.
And that there is neither Codetta nor Double Coda as a separate/single qlyph in SMuFL.

We could also change "Double" to "Doppio", to avoid that language mix.
I don't really care either way.

@mike-spa, what do you think about 'Double Coda', 'Doppio Coda' and 'Codetta'?

Ah, yes, we do have an Italian in the team ;-)

src/notation/view/selectionfiltermodel.cpp

shoogle

Please stop adding new things to the PR after it has been reviewed. It's ok to make improvements to approved functionality (e.g. if you spot another straight quote than needs to be replaced with a curly quote) but introducing an entirely new kind of change just delays merging further while we go through another round of approvals from all the different stakeholders (i.e. developers, designers, and the engraving team).

Ideally you should open separate PRs for each kind of change:

Disambiguate intervals and keys.
Replace straight quotes with curly quotes.
Use sentence case.
Replace "double coda" with "codetta" (this occurs in lots of places).
Other string changes (which only occur in one or two places each).

That way each PR only has to be approved by relevant stakeholders rather than by everybody, so changes can get merged faster.

src/palette/internal/palettecreator.cpp

shoogle · 2023-08-31T20:12:39Z

Also, it's not cool to bury one or two high-impact changes (like renaming a palette) in with a plethora of low-impact changes (like replacing straight quotes with curly quotes everywhere). That's exactly the kind of thing that might get merged accidently and then we'd just end up reverting it later on, only we couldn't (easily) revert it because it's combined with other changes, so that means more work... you get the idea!

Jojo-Schmitz · 2023-09-01T08:51:12Z

This is why this PR comes with a bunch of commits, you can easily review each and take the entire PR or just cherry-pick some commits and also can easily revert a commit, should it cause trouble.
I don't see how reviewing a number of PRs is easier than reviewing the same number of commits. IMHO the latter is less work.

I could squash all the Title Case vs. Sentence case commit into just one, I was using many because it was quite a big task, Just let me know.

shoogle · 2023-09-01T09:31:26Z

Yes, please squash the related commits, and mark the PR as 'draft' if you plan to make further changes.

Multiple commits are useful, but GitHub's 'Viewed' feature (to hide files that you've seen before) only works when you view the full diff, not the per-commit diffs, so there are advantages to using separate PRs.

But the main problem is that you keep adding unrelated changed to the PR after it has been approved. This requires another approval, often by different people, whereas if you only added related changes (like fixing another instance of title case) then we could still merge it based on the original approval.

Jojo-Schmitz · 2023-09-01T09:47:07Z

Done. No further changes planned (except for those requested in code review), so not coverted to draft

Jojo-Schmitz · 2023-09-01T12:00:16Z

No change, just a rebase

See https://musescore.org/en/node/353937 and musescore#19153

in: * masterpalette dialog * editdrumset dialog * editstyle dialog * voicingselect dialog * tuplet dialog * stafftextproperties dialog * specialcharacters dialog * selectnote dialog * realizeharmony dialog * pagesettings dialog * measureproperties dialog * keyedit dialog * editstringdate dialog * editstafftype dialog * editstaff dialog * editpitch dialog * breaks dialog * transpose dialog

See also the discussion from PR musescore#17748 Except for one, to avoid an MSVC compiler warning reg. decimal digit terminates octal escape sequence (C4125)

…otehead system" in Properties panel See musescore#19166

Jojo-Schmitz · 2023-09-05T13:28:34Z

AFAICT I did the changes that were requested, or didn't I?

shoogle · 2023-09-05T16:08:47Z

You've done what was requested so far, but @mike-spa is away for a couple of weeks so you'll have to drop the "Codetta" changes if you want to see the other changes merged before he returns.

Jojo-Schmitz · 2023-09-05T16:15:36Z

Done and separated out into another PR, #19294

Fix: Horizontal Distance from Notes -> Horizontal distance from notes - like 'Vertical distance from notes' in the same file (see musescore#19155). Greetings, Gootector

Fix: apostrophes/quotes Greetings, Gootector

Jojo-Schmitz force-pushed the translation-issues branch from 7a1a07b to b84171c Compare August 24, 2023 10:22

shoogle requested changes Aug 24, 2023

View reviewed changes

shoogle reviewed Aug 24, 2023

View reviewed changes

src/notation/view/widgets/transposedialog.ui Outdated Show resolved Hide resolved

shoogle added the strings Affects translatable strings label Aug 24, 2023

Jojo-Schmitz force-pushed the translation-issues branch from 955090c to 21a6326 Compare August 24, 2023 12:16

Jojo-Schmitz requested a review from shoogle August 24, 2023 12:16

Jojo-Schmitz force-pushed the translation-issues branch 3 times, most recently from 1e010c9 to beb4f45 Compare August 24, 2023 15:30

shoogle requested changes Aug 24, 2023

View reviewed changes

Jojo-Schmitz force-pushed the translation-issues branch from beb4f45 to 8e93df4 Compare August 25, 2023 07:49

shoogle approved these changes Aug 25, 2023

View reviewed changes

Jojo-Schmitz force-pushed the translation-issues branch from 50158b2 to 158d85d Compare August 25, 2023 12:15

shoogle reviewed Aug 25, 2023

View reviewed changes

Jojo-Schmitz force-pushed the translation-issues branch from 158d85d to f7fc84f Compare August 25, 2023 13:50

shoogle requested changes Aug 31, 2023

View reviewed changes

src/palette/internal/palettecreator.cpp Outdated Show resolved Hide resolved

Jojo-Schmitz force-pushed the translation-issues branch from f7fc84f to a78ecad Compare September 1, 2023 09:46

Jojo-Schmitz force-pushed the translation-issues branch 2 times, most recently from 95d899d to df859c2 Compare September 1, 2023 11:59

Jojo-Schmitz added 2 commits September 4, 2023 20:12

Fix GH#19153: Differentiating the meanings of "Minor" and "Major"

304f421

See https://musescore.org/en/node/353937 and musescore#19153

"notes" to "keys", as this is about the piano keyboard

8c23639

Jojo-Schmitz added 6 commits September 4, 2023 20:12

Plural for palettes

5068691

English plurals rather than Italian ones

4d39811

Use winged double quotes

780748a

See also the discussion from PR musescore#17748 Except for one, to avoid an MSVC compiler warning reg. decimal digit terminates octal escape sequence (C4125)

Better naming

992d829

Fix GH#19166: "Notehead scheme" in staff properties different from "N…

bb4d41c

…otehead system" in Properties panel See musescore#19166

Jojo-Schmitz force-pushed the translation-issues branch from df859c2 to d68c996 Compare September 4, 2023 18:12

Jojo-Schmitz force-pushed the translation-issues branch from d68c996 to bb4d41c Compare September 5, 2023 16:13

Jojo-Schmitz mentioned this pull request Sep 5, 2023

"Double Coda" to "Doppia Coda" #19294

Merged

shoogle approved these changes Sep 5, 2023

View reviewed changes

shoogle merged commit 98a7545 into musescore:master Sep 5, 2023
11 checks passed

Jojo-Schmitz deleted the translation-issues branch September 6, 2023 09:28

Gootector mentioned this pull request Sep 8, 2023

Fix: Horizontal Distance from Notes -> Horizontal distance from notes #19325

Closed

8 tasks

Gootector mentioned this pull request Sep 9, 2023

Fixes: Measure Repeats -> Measure repeats and more #19341

Merged

8 tasks

Gootector mentioned this pull request Oct 10, 2023

Fix: apostrophes and quotes #19670

Merged

8 tasks

Gootector referenced this pull request Nov 1, 2023

Fix: apostrophes/quotes

97229a8

Fix: apostrophes/quotes Greetings, Gootector

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Several Translation issues #19155

Several Translation issues #19155

Jojo-Schmitz commented Aug 24, 2023 •

edited

shoogle left a comment

Jojo-Schmitz commented Aug 24, 2023 •

edited

shoogle left a comment

cbjeukendrup commented Aug 25, 2023

Jojo-Schmitz commented Aug 25, 2023

shoogle commented Aug 25, 2023

shoogle Aug 25, 2023

oktophonie Sep 1, 2023

Jojo-Schmitz Sep 1, 2023 •

edited

shoogle Sep 1, 2023

Jojo-Schmitz Sep 1, 2023

shoogle left a comment

shoogle commented Aug 31, 2023

Jojo-Schmitz commented Sep 1, 2023 •

edited

shoogle commented Sep 1, 2023

Jojo-Schmitz commented Sep 1, 2023 •

edited

Jojo-Schmitz commented Sep 1, 2023

Jojo-Schmitz commented Sep 5, 2023 •

edited

shoogle commented Sep 5, 2023

Jojo-Schmitz commented Sep 5, 2023

Several Translation issues #19155

Several Translation issues #19155

Conversation

Jojo-Schmitz commented Aug 24, 2023 • edited

shoogle left a comment

Choose a reason for hiding this comment

Jojo-Schmitz commented Aug 24, 2023 • edited

shoogle left a comment

Choose a reason for hiding this comment

cbjeukendrup commented Aug 25, 2023

Jojo-Schmitz commented Aug 25, 2023

shoogle commented Aug 25, 2023

shoogle Aug 25, 2023

Choose a reason for hiding this comment

oktophonie Sep 1, 2023

Choose a reason for hiding this comment

Jojo-Schmitz Sep 1, 2023 • edited

Choose a reason for hiding this comment

shoogle Sep 1, 2023

Choose a reason for hiding this comment

Jojo-Schmitz Sep 1, 2023

Choose a reason for hiding this comment

shoogle left a comment

Choose a reason for hiding this comment

shoogle commented Aug 31, 2023

Jojo-Schmitz commented Sep 1, 2023 • edited

shoogle commented Sep 1, 2023

Jojo-Schmitz commented Sep 1, 2023 • edited

Jojo-Schmitz commented Sep 1, 2023

Jojo-Schmitz commented Sep 5, 2023 • edited

shoogle commented Sep 5, 2023

Jojo-Schmitz commented Sep 5, 2023

Jojo-Schmitz commented Aug 24, 2023 •

edited

Jojo-Schmitz commented Aug 24, 2023 •

edited

Jojo-Schmitz Sep 1, 2023 •

edited

Jojo-Schmitz commented Sep 1, 2023 •

edited

Jojo-Schmitz commented Sep 1, 2023 •

edited

Jojo-Schmitz commented Sep 5, 2023 •

edited