-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tuplet bracket when on notehead side #19438
Merged
cbjeukendrup
merged 3 commits into
musescore:master
from
miiizen:17852-tuplet-bracketing
Sep 29, 2023
Merged
Create tuplet bracket when on notehead side #19438
cbjeukendrup
merged 3 commits into
musescore:master
from
miiizen:17852-tuplet-bracketing
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Sep 19, 2023
bceefcc
to
288fcba
Compare
oktophonie
approved these changes
Sep 25, 2023
src/engraving/dom/tuplet.cpp
Outdated
@@ -194,7 +194,9 @@ bool Tuplet::calcHasBracket(const DurationElement* cr1, const DurationElement* c | |||
} | |||
bool tupletStartsBeam = beamStart->elements().front() == c1; | |||
bool tupletEndsBeam = beamEnd->elements().back() == c2; | |||
if (tupletStartsBeam && tupletEndsBeam) { | |||
bool headSide = isUp() != (c1->up() || c2->up()); | |||
bool isCross = c1->staffMove() || c2->staffMove(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cbjeukendrup
approved these changes
Sep 28, 2023
f9db5c6
to
ea93cd5
Compare
The VTests were unwilling, so I've rebased the branch, hoping that will help. |
oktophonie
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17852
When a tuplet's bracket type is set to auto, display a bracket if on the notehead side of beamed notes.