Fix #17074: Show placement inspector control for text-lines #20433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
Dec 12, 2023
|
When I save above/below as default and add another staff text, the option to save as default is greyed out. It is not grayed out when I do the same thing for staff/system text lines video1241311273.mp4 |
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
RomanPudashkin
approved these changes
Dec 13, 2023
mathesoncalum
force-pushed
the
17074-textline_placement_property
branch
from
96f79a0
to
6a6f7e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17074
Edit: Placement property defaults were being read incorrectly for system vs. text lines, corrected by this PR