Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13261: Update minimum distance field on offset change #20506

Merged
merged 1 commit into from Dec 18, 2023
Merged

Fix #13261: Update minimum distance field on offset change #20506

merged 1 commit into from Dec 18, 2023

Conversation

mathesoncalum
Copy link
Contributor

Resolves: #13261

cbjeukendrup
cbjeukendrup reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be possible to fix this by just adding loadProperties() in the callback for m_offset inside AppearanceSettingsModel::createProperties()?

@mathesoncalum
Copy link
Contributor Author

mathesoncalum commented Dec 15, 2023 •
edited

Wouldn't it be possible...

Yes indeed @cbjeukendrup, thank you!

@RomanPudashkin RomanPudashkin merged commit 74f8004 into musescore:master Dec 18, 2023
11 checks passed
@mathesoncalum mathesoncalum deleted the 13261-mindistance_offset_update branch December 29, 2023 09:44
@mathesoncalum mathesoncalum mentioned this pull request Jan 8, 2024
Merged
RomanPudashkin added a commit that referenced this pull request Jan 8, 2024
@RomanPudashkin
Merge pull request #20881 from mathesoncalum/421-porting
296e77b 
Port #20506 & #20433 to 4.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup left review comments

@oktophonie oktophonie oktophonie approved these changes

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees

@zacjansheski zacjansheski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimum distance field does not update when value changes
5 participants
@mathesoncalum @oktophonie @cbjeukendrup @RomanPudashkin @zacjansheski