fix #63711: no naturals on change to atonal key signature #2045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't run mtests yet; relying on Travis to do a first pass. I would plan to add some if nothing breaks. No hurry on merging this, but I welcome discussion.
My initial implementation of atonal key signatures just leveraged custom key signatures, making the case of a custom key sig with no symbols special. This doesn't work if we start adding naturals. So I have now moved to a more MusicXML-like implementation, where atonal key signatures are key of C but with a "mode" (a new attribute) of NONE. This also gives us a framework for modes of MAJOR & MINOR. The actual handling for the atonal key signatures is basically the same as before, but I no longer rely on them being custom or having no symbols - instead, I test mode == NONE directly (via a new isAtonal() function, analogus to isCustom()).