Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20923: Layout slash for notes without hooks or beams #20946

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Jan 10, 2024

Resolves: #20893

This PR lays out stem slashes for notes without hooks or beams, i.e. half and quarter notes.
Discussed with @oktophonie who decided laying out the slash for whole notes (or stemless notes) is not needed.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Jan 31, 2024
@mike-spa mike-spa merged commit 36ad315 into musescore:master Jan 31, 2024
10 of 11 checks passed
@XiaoMigros XiaoMigros deleted the stem-slash-fix branch January 31, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stem slashes misplaced on notes without hooks or beams
3 participants