Fix compile errors with Qt5.5 #2109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define debug methods even if QT_DEBUG is not set, because the new implementation of Q_ASSERT_X in Qt5.5 always requires all symbols to be defined.
|
I prefer to change all ASSERTs to NOPs in release mode to avoid any runtime penalty. |
|
See fc8fad9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define debug methods even if QT_DEBUG is not set,
because the new implementation of Q_ASSERT_X in Qt5.5
always requires all symbols to be defined.
importmidi defines some debug helper methods only when compiled with QT_DEBUG, which was fine up to Qt5.4. With Qt5.5, however, 'make' leads to compile errors. (See https://musescore.org/en/node/68051)
If it's OK to have the debug helpers included in the release version, this does fix the compilation problems with Qt5.5