Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to resize & rotate symbols #21110

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Jan 20, 2024

Resolves: #17116
Resolves: #18462
Resolves: #15522

This PR introduces the options to scale and rotate symbol elements. These options can be managed via the properties tab, where it's now possible to change the symbol's font as well.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros XiaoMigros changed the title symbols properties Options to resize & rotate symbols Jan 20, 2024
@XiaoMigros XiaoMigros force-pushed the symbols-properties branch 6 times, most recently from 9f17397 to 922946a Compare January 21, 2024 03:21
@XiaoMigros XiaoMigros force-pushed the symbols-properties branch 20 times, most recently from a7a4011 to 779a6e0 Compare January 31, 2024 11:28
@XiaoMigros XiaoMigros force-pushed the symbols-properties branch 5 times, most recently from be067a7 to 22cad81 Compare February 6, 2024 18:02
@bkunda
Copy link

bkunda commented Feb 7, 2024

@XiaoMigros I'd love to be able to review this, but the macOS build appears to have failed.

@XiaoMigros
Copy link
Contributor Author

Very sorry about that, @cbjeukendrup has told me that I'm not the only encountering this issue so I hope it can be resolved soon..

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 7, 2024

That failure looks similar to that from #21360

As other more recent PRs succeed, maybe a rebase helps?

@XiaoMigros
Copy link
Contributor Author

Seems to have worked!

Copy link

@bkunda bkunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @XiaoMigros :-)

  1. I wonder whether we really need the font dropdown? @oktophonie do any of the other music fonts currently support the symbols in the master palette?
  2. We need an icon for the button in properties (visible when multiple elements are selected).
Screenshot 2024-02-07 at 2 53 20 pm

I'd suggest @jessjwilliamson or @avvvvve whip up something for this and update the musescoreicon font (I don't mind who does it – you both can decide among yourselves :-))

@oktophonie
Copy link
Contributor

You can choose what music font to use in the master palette (by default, as of this PR, it'll be whatever music symbols font is currently in force). The font dropdown in Properties is the only means of changing this (which you may want or need to do it you ever change the music font, or for other supremely niche reasons).

The master palette shows SMuFL symbols, so they can exist in any SMuFL font.

@XiaoMigros XiaoMigros force-pushed the symbols-properties branch 3 times, most recently from b2b7f0d to 0a25472 Compare February 14, 2024 21:08
@bkunda bkunda self-requested a review February 15, 2024 09:28
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but generally looks good!

src/engraving/dom/symbol.cpp Outdated Show resolved Hide resolved
src/palette/view/widgets/symboldialog.cpp Outdated Show resolved Hide resolved
@cbjeukendrup cbjeukendrup merged commit 6e07516 into musescore:master Feb 15, 2024
11 checks passed
@XiaoMigros XiaoMigros deleted the symbols-properties branch February 16, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants