-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options to resize & rotate symbols #21110
Conversation
9f17397
to
922946a
Compare
a7a4011
to
779a6e0
Compare
be067a7
to
22cad81
Compare
@XiaoMigros I'd love to be able to review this, but the macOS build appears to have failed. |
Very sorry about that, @cbjeukendrup has told me that I'm not the only encountering this issue so I hope it can be resolved soon.. |
That failure looks similar to that from #21360 As other more recent PRs succeed, maybe a rebase helps? |
22cad81
to
7c5f885
Compare
Seems to have worked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @XiaoMigros :-)
- I wonder whether we really need the font dropdown? @oktophonie do any of the other music fonts currently support the symbols in the master palette?
- We need an icon for the button in properties (visible when multiple elements are selected).
![Screenshot 2024-02-07 at 2 53 20 pm](https://private-user-images.githubusercontent.com/86290556/303003659-a2576352-7e95-4e65-a5c1-b2c3087da5ce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NTIwNTcsIm5iZiI6MTcyMjk1MTc1NywicGF0aCI6Ii84NjI5MDU1Ni8zMDMwMDM2NTktYTI1NzYzNTItN2U5NS00ZTY1LWE1YzEtYjJjMzA4N2RhNWNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA2VDEzNDIzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhZmU1M2Y4NWQwMWJiYTRjYjU3N2FiYjQ3ZjkzMTc3YzZiMjc5NjA4NmZmYjg5ZDYyMzQyMWUyMjkyOTIxZWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WSyPcrE1Mufxr0h1XOcsjFSI19HdNliquUuQ873pwTk)
I'd suggest @jessjwilliamson or @avvvvve whip up something for this and update the musescoreicon font (I don't mind who does it – you both can decide among yourselves :-))
You can choose what music font to use in the master palette (by default, as of this PR, it'll be whatever music symbols font is currently in force). The font dropdown in Properties is the only means of changing this (which you may want or need to do it you ever change the music font, or for other supremely niche reasons). The master palette shows SMuFL symbols, so they can exist in any SMuFL font. |
fa1f8d3
to
525a11a
Compare
b2b7f0d
to
0a25472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, but generally looks good!
src/framework/uicomponents/qml/MuseScore/UiComponents/IncrementalPropertyControl.qml
Outdated
Show resolved
Hide resolved
0a25472
to
d7bfb50
Compare
Resolves: #17116
Resolves: #18462
Resolves: #15522
This PR introduces the options to scale and rotate symbol elements. These options can be managed via the properties tab, where it's now possible to change the symbol's font as well.