Fix cross staff tie layout #21192
Fix cross staff tie layout #21192
Conversation
miiizen
force-pushed
the
20747-cross-ties
branch
3 times, most recently
from
3863949
to
6afac52
Compare
|
|
||
| return (startN && startN->chord()->staffMove() != 0) || (endN && endN->chord()->staffMove() != 0); | ||
| return (startChord && (startChord->staffMove() != 0 || startChord->vStaffIdx() != staff)) | ||
| || (endChord && (endChord->staffMove() != 0 || endChord->vStaffIdx() != staff)); |
There was a problem hiding this comment.
Could you explain why we need to add the chord->vstaffIdx() != staff condition? At a first glance it looks redundant to me, cause it can only be true if at least one chord has staffMove() != 0. Or is there a case that I'm not thinking of?
There was a problem hiding this comment.
This is needed when the tie starts on a note on staff 0 (the tie's staff is 0) and ends on a note on staff 1. In this case neither chord is currently moved but the tie should still be cross staff. (eg. the first case in the attached screenshot)
| @@ -1556,6 +1558,10 @@ TieSegment* SlurTieLayout::tieLayoutBack(Tie* item, System* system, LayoutContex | |||
| segment->setSystem(system); | |||
| segment->resetAdjustmentOffset(); | |||
|
|
|||
| if (chord) { | |||
| segment->setStaffIdx(chord->vStaffIdx()); | |||
There was a problem hiding this comment.
This feels slightly hacky (and slightly dangerous) cause you are changing the staffIdx of only one of the TieSegments, so you end up with mismatching tracks between the Tie item and its two TieSegments. Anyway, this is such an edge case that, if it works properly, I think we can keep the hack, for once, as it does make it all quite simple. Maybe do write a small hack-warning comment to explain that though :)
There was a problem hiding this comment.
Ah yeah, having a vStaffIdx field for tie segments would absolutely be safer - I can try to make that work
miiizen
force-pushed
the
20747-cross-ties
branch
from
6afac52
to
ecc953f
Compare
oktophonie
requested review from
cbjeukendrup
and removed request for
RomanPudashkin
Resolves: #20747
Fix layout of cross staff ties on the same system and between systems.
