generates unrolledTempomap from RepeatList and original graphical TempoMap #2133
Conversation
| @@ -10,6 +10,7 @@ | |||
| // the file LICENCE.GPL | |||
| //============================================================================= | |||
|
|
|||
| #include <QtCore/QtDebug> | |||
There was a problem hiding this comment.
this is not needed. It's already included in all.h.
There was a problem hiding this comment.
sorry, please remove it then. For some reason debug mode failed in eclipse when I first ran the original master branch.
|
In light of the revelation that section breaks can occur on non-measure frames, I'm canceling this earlier pull request. Also another thing I now need to be aware of is: if a section ends on a fine, then it doesn't have a section break immediately after it, and hence would incorrectly not incur a pause when should actually have one. I will open up a new PR, and will probably implement my initially suggested "tick shift" method. Once #2172 gets merged, the modified unwind() will only produce RepeatSegments that never cross SECTION_BREAK boundaries. Therefore, I think I just would need to make a note during unwinding about which RepeatSegments start on a section break (could be a boolean variable in RepeatSegment, such as "isAfterSectionBreak"). Those RepeatSegments and their measures will have their initial tick value be increased by one, which could probably be handled when RepeatList::update() is called. I will not try to generate an unrolled tempomap for my next PR...I'll leave that for another feature request. |
See https://musescore.org/en/node/32696#comment-321096 for summary.