-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cross-staff beam position controls #21860
New cross-staff beam position controls #21860
Conversation
@@ -142,6 +142,7 @@ static constexpr PropertyMetaData propertyList[] = { | |||
{ Pid::BEAM_POS, false, 0, P_TYPE::PAIR_REAL, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "beam position") }, | |||
{ Pid::BEAM_MODE, true, "BeamMode", P_TYPE::BEAM_MODE, PropertyGroup::APPEARANCE, DUMMY_QT_TR_NOOP("propertyName", "beam mode") }, | |||
{ Pid::BEAM_NO_SLOPE, true, "noSlope", P_TYPE::BOOL, PropertyGroup::APPEARANCE, DUMMY_QT_TR_NOOP("propertyName", "without slope") }, | |||
{ Pid::BEAM_CROSS_STAFF_MOVE, true, "crossStaffMove", P_TYPE::INT, PropertyGroup::APPEARANCE, DUMMY_QT_TR_NOOP("propertyName", "beam staff move") }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could better align with the other entries in this list
9aa05d5
to
302c2a2
Compare
302c2a2
to
9246642
Compare
828ca8d
to
31553e2
Compare
Love this PR @mike-spa 🥰 Screen.Recording.2024-03-13.at.2.02.36.pm.mov |
Ah yes, I think that's a trivial fix, I'll do it on this PR |
9da026e
to
d236d88
Compare
Actually I may need some help @cbjeukendrup with that keyboard navigation issue. I can't quite understand why it's still not working despite the changes I've made in the last commit |
Resolves: #18687
Resolves: #19406
Resolves: #14649
Resolves: #21859
First, I've reintroduced the Auto/Up/Down control for beams (they got lost between version 3 and 4). Now for standard (i.e. non cross-staff) beams you get the standard Auto/Up/Down, and for cross-staff beams you get a new Move Up/Down control.
This is how the new controls work. Older files, which didn't have this option, get correctly migrated and cross-staff beams are mapped to the new option.
20240307_174308.mp4