Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-align measure-anchored text to the barline #22554

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Apr 24, 2024

Resolves: #22247

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 24, 2024

The VTests show issues, before:
layout-sequence-11-1 ref
after:
layout-sequence-11-1
See #22554 (comment)

Edit: fixed now ;-)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 24, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 27, 2024

Vtest shows the change for the better:
text-barline-alignment-1 diff

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 27, 2024
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Apr 29, 2024
@cbjeukendrup cbjeukendrup merged commit 4b9397f into musescore:master Apr 29, 2024
10 of 11 checks passed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default position of redirection incorrect
4 participants