Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set PopupView as parent of PopupWindow_QQuickView" #22644

Merged
merged 1 commit into from
May 1, 2024

Conversation

cbjeukendrup
Copy link
Contributor

This reverts commit 09200b3. That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (#22640 and #22641). Therefore, we'll revert this commit for now.

Resolves: #22640
Resolves: #22641

This reverts commit 09200b3.
That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (musescore#22640 and musescore#22641). Therefore, we'll revert this commit for now.
@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#22640 FIXED
#22641 FIXED

@Eism Eism merged commit f037257 into musescore:4.3.0 May 1, 2024
11 checks passed
@cbjeukendrup cbjeukendrup deleted the 430_fix_popupview_problems branch May 1, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants