Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Set PopupView as parent of PopupWindow_QQuickView" #22681

Merged
merged 1 commit into from
May 13, 2024
Merged

Revert "Set PopupView as parent of PopupWindow_QQuickView" #22681

merged 1 commit into from
May 13, 2024

Commits on May 4, 2024

  1. Revert "Set PopupView as parent of PopupWindow_QQuickView" 

    This reverts commit 2fa36e3.
That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (musescore#22640 and musescore#22641). Therefore, we'll revert this commit for now.
    @cbjeukendrup
    cbjeukendrup committed May 4, 2024
    Configuration menu
    Copy the full SHA
    1a82b43 View commit details
    Browse the repository at this point in the history