Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional update accidental #227

Closed
wants to merge 1 commit into from

Conversation

Isenbarth
Copy link

Adds a new mode for changing accidentals. When pressing the ALT-key while dropping an accidental from the palette or clicking one of the accidental buttons, the new accidental will be valid for the whole measure resp. the next accidental on the same line. I ou need this often when correcting a score.

@Jojo-Schmitz
Copy link
Contributor

Is this PR still valid? Does it still apply cleanly or does it need rework to ajdust with the meanwhile changed code base?

@Isenbarth
Copy link
Author

It is yet valid. If it still applies, I actually do not know, because I did not work any more on this version, after I got no help
for solving a simple formal test problem occuring with my code.

I would like to contribute this and some more improvements, that I meanwhile added to Version 1.2, because I need and use them
nearly every day and would like to use them in coming version 2 as well. If you are really interested, I would check #227 with the
actual code base and adapt it if necessary, but I will need one or two weeks for that.


Von: Joachim Schmitz [mailto:notifications@github.com]
Gesendet: Mittwoch, 13. November 2013 13:12
An: musescore/MuseScore
Cc: Isenbarth
Betreff: Re: [MuseScore] additional update accidental (#227)

Is this PR still valid? Does it still apply cleanly or does it need rework to ajdust with the meanwhile changed code base?

Reply to this email directly or view #227 (comment) it on GitHub.
https://github.com/notifications/beacon/vgsH9dxpQ3lAe3xeBS8GkESwSe0-8TPS1kBwkjC56lV-jvJxJxTUMoJl1rabF0NR.gif

@Jojo-Schmitz
Copy link
Contributor

One thing that might be helpful to move this forward, is to open a thread in the forum or an issue in the issue tracker.

@Isensee
Copy link
Contributor

Isensee commented Nov 14, 2013

ok. I just opened an issue in the tracker (#23543), will close this push request and generate a new one after testing my changes with the actual code.

@Jojo-Schmitz
Copy link
Contributor

You man need to sign the CLA again, with your changed username

@Jojo-Schmitz
Copy link
Contributor

#564 is the replacement for this, right?

@Isensee
Copy link
Contributor

Isensee commented Nov 23, 2013

Yes. This one can be closed. The new one #564 works fine with the actual code, but I am yet struggling to solve some problems with the environment.

@Jojo-Schmitz
Copy link
Contributor

I think only you can close it?

@lasconic lasconic closed this Nov 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants