Improved distances and centering of cross-staff beams #23575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
improvedDistancesAndCenteringOfCrossStaffBeams
branch
from
fad9643
to
1b9c049
Compare
oktophonie
approved these changes
Jul 12, 2024
miiizen
reviewed
Jul 12, 2024
| @@ -2404,30 +2405,50 @@ double SystemLayout::minVertSpaceForCrossStaffBeams(System* system, staff_idx_t | |||
| if (!beam || !beam->cross() || !beam->autoplace() || beam->elements().front() != item) { | |||
There was a problem hiding this comment.
A small suggestion for efficiency - as we now cache the beams cross staff position (above/below/between), this can be checked here
... || beam->ldata()->crossStaffBeamPos != BeamBase::CrossStaffBeamPosition::BETWEEN)
mike-spa
force-pushed
the
improvedDistancesAndCenteringOfCrossStaffBeams
branch
from
1b9c049
to
98d3f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23553
The minimum staff distance for cross-staff beams is computed by summing the minimum allowed stem length of the lowest note above and highest note below the beam. My original implementation however didn't take into account that stems from above and from below overlap each other within the height of the beam itself, hence why the resulting space was excessive.
Additionally, we now measure the distance between first and last beam segment (which for cross-staff beams can be both above and below the beam centerline) and use it to center the beam more precisely.
The action of the fixed-width spacer is now also restored, which allows to fine tune if necessary.