Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pre-2.0 compatibility stuff #2576

Closed

Conversation

Jojo-Schmitz
Copy link
Contributor

there's probably quite a bit more, but these are the obvious places

@lasconic
Copy link
Contributor

Ideally, it would be great to regroup all this stuff in a single file instead of delete it. In a short discussion with Werner, he suggested to create a completely separated file to load press 2.0 files, something similar to the importxml files.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented May 2, 2016

OK, so I've for now just removed 114 > mscVersion() < 206, i.e. all the post-1.3 and pre-2.0.0 stuff.

oops, looks like a lot of the mtest files are pre-2.0.0, mscVersion() < 206

I can go ahead and fix them, if this PR in General is going into the right direction, otherwise I'd rather not invest the time. Just let me know.

@lasconic
Copy link
Contributor

lasconic commented May 2, 2016

I believe it does. Only little problem is that we will need to update the test over and over again if we increment the format numbers like we did between 1.3 and 2.0.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented May 2, 2016

Well, we'd need to do it again for MuseScore 4.0 ;-)
We may need to do some mtests files again due to other test failures caused by format changes, but that was the case during 2.0 development too.

Question is which version to use to rewrite them now, latest master or plain 2.0.0, or something in between?

For now I've just changed them all to 2.07 using sed

@Jojo-Schmitz
Copy link
Contributor Author

sorry, somehow I managed to fat-finger this PR. New on at #2581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants