remove post 1.3 and pre-2.0 compatibility checks and tweaks #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2016
Jojo-Schmitz
force-pushed
the
remove-pre-2.0-stuff
branch
4 times, most recently
from
e4b1808
to
6477888
Compare
| @@ -1734,7 +1734,7 @@ void Measure::read(XmlReader& e, int staffIdx) | |||
| breath->setTrack(e.track()); | |||
| int tick = e.tick(); | |||
| breath->read(e); | |||
| if (score()->mscVersion() < 205) { | |||
| if (score()->mscVersion() <= 206) { | |||
| // older scores placed the breath segment right after the chord to which it applies | |||
There was a problem hiding this comment.
I think the problem is what is described in the comment here. The current selectionfilter13.mscx file was version 200, so it was less 205, it maybe should be renewed.
There was a problem hiding this comment.
Outch! I thought this would not be any functional change (I apparently read the < as a >, but now I see that it is.
Thanks for catching it
Jojo-Schmitz
force-pushed
the
remove-pre-2.0-stuff
branch
from
6477888
to
295ebf8
Compare
|
Quick discussion with Werner. It's better to use 2.06 for tests... Sorry for the late answer. |
Jojo-Schmitz
force-pushed
the
remove-pre-2.0-stuff
branch
3 times, most recently
from
bb599ac
to
e2522cf
Compare
Jojo-Schmitz
force-pushed
the
remove-pre-2.0-stuff
branch
from
476a6c2
to
565d5c5
Compare
|
sorry, somehow I once again managed to fat-finger and close this PR. New one at #2598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's probably quite a bit more, but these are the most obvious places.
Impoved the error mssage, with a hint where to get 2.0.
Most of the templates and sample scores had been created with a pre2.0 nightly version, so they have been resaved with 2.0.0. They'll most probably need to get updated for 3.0 at some point again.
The mtest files I've all changed to 2.07 using
sedmaybe I should have picked 2.06...
Any idea anybody why that 1 remaining mtest fails? And more importantly: how to fix it?