-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #111531 (Create marching ensemble templates) #2625
Conversation
You need to add the new files and update the changed file's name in .../share/templates/CMakeLists.txt |
While at it, if you edit the commit message to include "Fix #111531", then the issue in the tracker will automatically be marked as fixed when this PR is merged. |
You still need to add the new files and update the changed file's name in .../share/templates/CMakeLists.txt, to get the 'make install' step working. |
I thought that making CMakeLists.txt was precisely what commit 9df7b91 was for. Did my changes not actually go through, or did I make a mistake in adding the new files? |
Oops, sorry, didn't notice that. However, Travis still fails: |
@@ -77,7 +77,10 @@ install(FILES | |||
|
|||
install(FILES | |||
07-Band_and_Percussion/01-Concert_Band.mscz | |||
07-Band_and_Percussion/02-Marching_Percussion.mscz | |||
07-Band_and_Percussion/02-Marching_Band.mscz | |||
07-Band_and_Percussion/03-Marching_Percussion_(battery).mscz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it 07-Band_and_Percussion/03-Marching_Percussion_\(battery\).mscz
, i.e. 'escape' the parens with a backslash
Travis seems to be failing something about |
The breath add is my fault. I'm fixing it. |
Can you squash your 3 commits together? See http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html |
Added templates for a marching band and two sizes of marching percussion ensemble. The marching percussion templates were originally called “WGI”, but they also work nicely for marching bands that follow the workflow of having their fully-realised percussion parts written separately. NOTE: divisional linked parts are *not* part of these templates, as they may slow things down too much. If you want these templates with the divisional parts, e-mail chris@euchre.us
22b3aeb
to
5e35de9
Compare
I've squashed the commits. Note for any future readers (mostly myself): the GitHub desktop application doesn't push squashed commits (it instead separates them back out and restores the ones that it has on its servers). Instead, use |
@duck57 I just merged it in master but forgot to make you sign the MuseScore CLA. Could you take a look to https://musescore.org/en/cla and sign it? Thanks! |
I've sent in the CLA. |
Thank you ! |
Added templates for a marching band and two sizes of marching
percussion ensemble.
The marching percussion templates were originally called “WGI”, but
they also work nicely for marching bands that follow the workflow of
having their fully-realised percussion parts written separately.
NOTE: divisional linked parts are not part of these templates,
as they may slow things down too much. If you want these templates
with the divisional parts, e-mail chris@euchre.us