Fix issue #115806: round robin not working #2680
Conversation
hpfmn
force-pushed
the
ZerberusRoundRobin
branch
from
5cd7c39
to
625dcff
Compare
|
Round robin general works by having a sequence length and a sequence position. The current position in the sequence should advance each time a note is played that corresponded to that zone - but a note in that zone just gets played if it's position is the same as the current one of the sequencer. So currently Zerberus checks whether the current seq position is the same as the desired position but it only advances the general position if that check is positive. But has to advance always - but just returning true if it matches! |
|
Looks good. There is another thing missing though. We read lorand and hirand but we don't do anything with it, so I guess we are always playing the samples in the seq order. |
| @@ -50,18 +50,19 @@ bool Zone::match(Channel* c, int k, int v, Trigger et) | |||
| && (k <= keyHi) | |||
| && (v >= veloLo) | |||
| && (v <= veloHi) | |||
| && (seq == seqPos) | |||
| //&& (seq == seqPos) | |||
There was a problem hiding this comment.
Oh and if you could remove this line, if it's not useful, better to not keep it commented.
This fixes the not working round robin