fix #116586: load sfz in background #2700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpfmn
force-pushed
the
ZerberusLoadSFZBackground
branch
from
e0cf890
to
4187b0a
Compare
| _progressDialog->exec(); | ||
| _progressDialog->open(); | ||
| _progressBar = Ms::mscore->showProgressBar(); | ||
| _progressBar->setFormat(tr("Loading sfz %p%")); |
There was a problem hiding this comment.
The last percent(%) in the format string should also be escaped!
hpfmn
force-pushed
the
ZerberusLoadSFZBackground
branch
from
4187b0a
to
a2e8f1f
Compare
|
It's a good idea to use the MuseScore progress bar, so the UI is not blocked by a progress dialog. But from a code perspective, it's not really good to have Zerberus relying on MuseScore. It would maybe be better to send progress information in a signal and have someone listening to this information. For example, MuseScore could listen to it and display progress information in its progress bar. I close this PR, feel free to do a better one based on my comment (or not :) |
| @@ -14,8 +14,23 @@ include (${PROJECT_SOURCE_DIR}/build/gch.cmake) | |||
|
|
|||
| QT5_WRAP_UI (zerberusUi zerberus_gui.ui) | |||
|
|
|||
| include_directories( | |||
There was a problem hiding this comment.
Not really sure why all of this should be added here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load sfz files in background and display a progress bar in the status bar