141581 jianpu #2957

byan61 · 2017-01-08T18:01:01Z

This is initial implementation of Jianpu staff display and adding a linked Jianpu staff from a Standard staff.
The implementation is just a start and is by no means a complete one yet.
Currently display of octave dots is limited to one dot.
Supports for duration augmenting dots, grace notes, spanners, etc., are not there yet.
There are also some TODO items marked in the code.

lasconic · 2017-01-08T18:37:46Z

Hi, thank you for the PR. Two things:

I need you to sign the MuseScore CLA in order to pull your code into master https://musescore.org/en/cla
Your PR cannot be merged as it. It has several conflicts with master. You will need to rebase and fix the conflicts.

libmscore/CMakeLists.txt
libmscore/barline.cpp
libmscore/element.h
libmscore/layout.cpp
libmscore/measure.cpp
libmscore/staff.cpp
libmscore/staff.h
libmscore/stafftype.cpp
libmscore/system.cpp

byan61 · 2017-01-08T22:09:04Z

Done with #1.
For #2, I merged Jianpu changes with latest from master branch.
But, after the merge, Jianpu barlines and Jianpu beams do not work anymore.
I'm now working to fix these.

byan61 · 2017-01-09T05:49:33Z

Merge conflicts have been resolved. It's ready for review.
Reading/writing Jianpu staff from/to the score file is not implemented yet.
So, if you test Jianpu staff display by adding a linked Jianpu staff, do not save your score file. Otherwise your score file may get corrupted.

lasconic · 2017-01-09T05:52:24Z

It seems your code cannot be compiled, see https://travis-ci.org/musescore/MuseScore/jobs/190151221#L1926

byan61 · 2017-01-09T06:07:42Z

Sorry, some files were left out accidentally.
They have been pushed now.

lasconic · 2017-01-09T06:15:39Z

No problem. The CI is running. Next thing will be to squash all your commits together to not pollute the history of the repo. See http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

lasconic · 2017-01-09T06:22:51Z

CI is still failing https://travis-ci.org/musescore/MuseScore/jobs/190154341#L1998

Jojo-Schmitz · 2017-01-09T07:48:30Z

Some mtests are failing, namely tst_midimapping, see https://travis-ci.org/musescore/MuseScore/jobs/190164161#L5105
And I think I know why, see my other comments

Jojo-Schmitz · 2017-01-09T07:54:44Z

libmscore/stafftype.cpp

@@ -1384,6 +1386,7 @@ void StaffType::initStaffTypes()
         StaffType(StaffGroup::PERCUSSION, "perc1Line", QObject::tr("Perc. 1 line"),    1, -4,    1,   true,  true, false, true, false, true),
         StaffType(StaffGroup::PERCUSSION, "perc3Line", QObject::tr("Perc. 3 lines"),   3, 0,     2,   true,  true, false, true, false, true),
         StaffType(StaffGroup::PERCUSSION, "perc5Line", QObject::tr("Perc. 5 lines"),   5, 0,     1,   true,  true, false, true, false, true),
+         StaffType(StaffGroup::JIANPU,     "jianpu",    QObject::tr("Jianpu"),          0, 0,     1,  false,  true, false, true, false, false),


I believe this is why the mtest fail, here you insert Jianpu (better append it IMHO)

Jojo-Schmitz · 2017-01-09T07:55:06Z

libmscore/stafftype.h

@@ -155,6 +155,7 @@ enum class StaffTypes : signed char {
      TAB_6SIMPLE, TAB_6COMMON, TAB_6FULL,
            TAB_4SIMPLE, TAB_4COMMON, TAB_4FULL,
            TAB_UKULELE, TAB_BALALAJKA, TAB_ITALIAN, TAB_FRENCH,
+      JIANPU,


whereas here you append jianpu (IMHO a good choice)

Jojo-Schmitz · 2017-01-09T07:55:38Z

libmscore/stafftype.h

@@ -243,6 +244,11 @@ class StaffType {
      static QList<TablatureDurationFont> _durationFonts;
      static std::vector<StaffType> _presets;

+      // Jianpu: configurable properties
+      // TODO: read them from configuration file.
+      QFont _jianpuNoteFont = QFont("Times New Roman", 11.0, QFont::Bold); // font used to draw Jianpu notes/rests.


Better use FreeSerif or FreeSans, these are delivered with MuseScore, Times New Roman is not and not available on some platforms

byan61 · 2017-01-10T03:16:06Z

Thanks, Jojo.
I made the corrections and pushed the commit.

Jojo-Schmitz · 2017-01-10T08:07:55Z

Looks better ;-)
Now you'd just need to squash these commits (see @lasconic's hint above) , preferably with a commit title in the form of "fix #141581: implement Jianpu staff display", so the corresponding issue gets marked fixed automagically when this PR gets merged.
Then again that squashing may wait until read/write has been implemented too

byan61 · 2017-01-11T06:21:09Z

I'll be working on read/write part before squashing the commits.

byan61 · 2017-01-16T08:03:05Z

After adding read/write and saving the score file with Jianpu linked staff, staves that are below Jianpu staff are not displayed at all when the file is opened. Display of Jianpu staff and staves above it are working fine. The layout functions of elements from the staves in question are called but the draw functions do not get called. Verified with debugger that these elements are added to the BspTree by scanElements function. Any idea why draw function of these elements do not get called?

Jojo-Schmitz · 2017-02-01T15:17:47Z

A rebase is needed. And I guess this PR should get tagged as Work in Progress

lasconic · 2017-02-05T22:43:52Z

I quickly try the PR. I created a score for Flute, pressed i, and added a Jianpu linked staff. Then I entered some note in the standard flute staff. And I got this

byan61 · 2017-02-06T01:13:51Z

Note entry and editing for Jianpu has not been implemented yet, so this will not work.
Only display of Jianpu from existing Standard notation score file is implemented so far.
Try opening an existing score file and adding a linked Jianpu Staff to an existing Standard staff.

byan61 · 2017-02-06T01:50:18Z

Arr... I just tried opening an existing score file and adding Jianpu staff and the display of Jianpu staff does not work anymore after merging with latest from the base branch. I'll work to fix that.

lasconic · 2017-02-06T09:14:14Z

Sorry for that. It's true that the current master is a bit of a moving target right now. Feel free to ask for help if needed.

byan61 · 2017-02-14T04:25:16Z

Sorry that I've been busy at work and at home and have not had much time to focus on this yet. Any help is welcome including pointing out what might be causing the Jianpu display issue.

byan61 · 2017-04-19T04:49:00Z

Issue of Jianpu staff display has been fixed now.

byan61 · 2017-04-21T02:10:15Z

@lasconic and @Jojo-Schmitz: Can you take a look and merge the PR if it's acceptable? Thanks.

lasconic · 2017-04-21T06:39:46Z

@byan61 sure, give us some time though, we are trying to release MuseScore 2.1 asap.

byan61 · 2017-05-19T14:39:13Z

I have fixed the remaining compiler warnings and pushed a new commit, hopefully the last one for this PR. Please take a look.

byan61 · 2017-05-24T02:15:28Z

@lasconic and @Jojo-Schmitz: Can you take a look and merge the PR if it's acceptable so that I can move on to the next step? Thanks.

Jojo-Schmitz · 2017-05-24T07:30:50Z

@byan61: code looks OK to me, I haven't actually tested any of it though. And I can't merge.

byan61 · 2017-06-23T03:48:09Z

@lasconic and @Jojo-Schmitz: It's been a month now. Any chance for testing and to get it merged?

sirsoweird · 2017-12-30T14:38:48Z

@lasconic @Jojo-Schmitz @byan61 I'd love to help test this, however I had a hard time getting a build going for either Windows or Linux. Could anyone put something together for Windows so a few of us could test and give feedback? Sorry I'm not an expert programmer, but I'll help where I can.

sirsoweird · 2018-01-12T14:46:57Z

I finally got my build up and running. Just giving it a few quick tests.

A few thoughts: in the top line, the Jianpu underline went down when the notes went above B
Standard Jianpu would have the under-dots below the under-lines.
Measure 7 shows a dotted half; the dot should not show for halves or longer notes. The length of the note is only indicated by the number of dashes after the note. For the dotted half, it should have two dashes after the note.

lasconic · 2018-01-12T14:57:03Z

Did you rebase on master and fix the conflicts? if yes, can you open a new PR ?

sirsoweird · 2018-01-18T06:35:00Z

No, I didn't rebase with master. I'm still very interested in this project, however I'm not going to have much time to work on it for a while here. Not sure where @byan61 is with this, he doesn't seem to be very active currently. If we want to get back on track with this project, what would the steps be?

lasconic · 2018-01-18T09:43:34Z

Hi,
First step would be to rebase to current master. Then fix the issues you mentioned, preferably with reference to an authoritative source. The problem with Jianpu is that there are several ways to notate it. If MuseScore includes one way, we will need a source to defend the implementation. Then the implementation needs to be clean up. The use of friend class makes it hard to read.

dannysalim · 2018-03-12T14:41:39Z

Hi, I am Danny Salim and am interested to continue this project.

lasconic · 2018-04-06T19:51:13Z

See PR #3614 for a rebased version.

odhot · 2018-12-31T05:01:28Z

I finally got my build up and running. Just giving it a few quick tests.

A few thoughts: in the top line, the Jianpu underline went down when the notes went above B
Standard Jianpu would have the under-dots below the under-lines.
Measure 7 shows a dotted half; the dot should not show for halves or longer notes. The length of the note is only indicated by the number of dashes after the note. For the dotted half, it should have two dashes after the note.

hi, i have working on your version but for indonesian numbered notation .. where can i contact you sir ?

odhot · 2018-12-31T05:07:54Z

here's the sample .. but our sharp and flat is different ..

Jojo-Schmitz · 2018-12-31T14:45:36Z

@odhot better go to #3614, as that is still open (but does need a rebase meanwhile)

Buronan13 · 2019-01-22T12:02:31Z

@odhot boleh minta nomor wa atau ig atau nama fb kmu tidak?
Saya juga lagi cari cara membuat not angka di musescore tpi gak ketemu2?

David-C0pperfield · 2020-02-28T15:54:34Z

A year later...

Jojo-Schmitz · 2020-02-28T15:56:26Z

this is still closed and #3614 still open...

sherlockholmestech · 2020-04-16T01:12:49Z

smusic.zip
Consider this for jianpu notation only, unlinked.

odhot · 2020-04-16T02:12:13Z

smusic.zip
Consider this for jianpu notation only, unlinked.

different ... our numeric notation has different flag position

Thethnan · 2020-10-13T04:23:16Z

@lasconic @Jojo-Schmitz @byan61 I'd love to help test this, however I had a hard time getting a build going for either Windows or Linux. Could anyone put something together for Windows so a few of us could test and give feedback? Sorry I'm not an expert programmer, but I'll help where I can.

How to get this jianpu view note sheet.

Thethnan · 2020-10-13T04:25:23Z

I would like to get jianpu staff note to numbered note auto convert, please help me.

Jojo-Schmitz · 2020-10-13T06:10:39Z

this PR has been closed 2 1/2 years ago and work continued in #3614.
That in turn had been closed meanwhile too though, but if anything that'd be the one to continue on.

oorfeo · 2021-09-02T15:30:01Z

Last comment until now was Oct. 2020.
I'm Don Rechtman, a U.S. citizen currently residing in Shenzhen. More than one billion people here in China read, compose and perform using numbered Jianpu notation. If this project can be successfully completed, the Musescore community should receive a dramatic boost in size.
I'm available to beta and alpha any plugin work, and have resources to comment on suggestions for items for inclusion.

Jojo-Schmitz · 2021-09-02T15:35:36Z

See #3614, that one is at least quite a bit newer

oorfeo · 2021-09-02T17:14:02Z

Thanks for the response! � Yeah, that’s the one I was originally responding to. As a newbie to the discussion, it is a little difficult for me to understand exactly what was and is going on with the development of the plugin. � Also, having done programming, QA and technical writing in the past, I know the difficulties of implementation of seemingly simple ideas: Manager: “Move the OK button to the other side; can you do that this afternoon?” Programmer: “Actually, it’s going to take about two weeks to make it happen.” � I’ve manually “translated” Western notation to Jianpu and back again for various music groups here. A lot of professional traditional Chinese singers are not trained in Western notation, and it also took me a fair amount of practice to master some of the more subtle aspects of Jianpu notation. Additionally, there are specialized characters and symbols for nuances on different instruments and even for different Ethnic and regional styles of singing. If the basics are able to be bullet-proofed (rhythm, pitch, key and tempo identification, multiple parts, lyrics), it should then be easier to customize for individual instruments and styles. � Please do let me know if there’s any way I might assist with the development. � Peace, � Don � Don “Orfeo” Rechtman �(唐瑞民) 53 Wutong Shan Shi Chang Keng Bei Cun, Luohu District, Shenzhen, Guangdong, China 518020 广东省深圳市罗湖区梧桐山市场坑背村53号 518020 Phone (China): �(+86) 135-2889-6144 Weixin (WeChat) name: � oorfeo www.OrfeoMusic.org <http://www.orfeomusic.org/> “Delve into tradition with the utmost dedication and then break away from it with the utmost courage.” Li Keran (1907-1989), a prominent figure in 20th-century Chinese art � � From: Joachim Schmitz ***@***.***> Sent: Thursday, September 2, 2021 11:36 PM To: musescore/MuseScore ***@***.***> Cc: oorfeo ***@***.***>; Comment ***@***.***> Subject: Re: [musescore/MuseScore] 141581 jianpu (#2957) � See #3614 <#3614> , tht one is at least quite a bit newer — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2957 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATZJIRCXQURHOFW4GSB4SGTT76KVHANCNFSM4C3XAJWA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .

byan61 force-pushed the 141581-jianpu branch from 3ce48ca to 771c2c4 Compare January 9, 2017 06:04

Jojo-Schmitz reviewed Jan 9, 2017

View reviewed changes

byan61 force-pushed the 141581-jianpu branch from 04962c4 to cd90cd7 Compare January 10, 2017 02:58

byan61 force-pushed the 141581-jianpu branch from cd90cd7 to 0d4aeb6 Compare February 1, 2017 15:27

lasconic added the work in progress not finished work or not addressed review label Feb 1, 2017

byan61 force-pushed the 141581-jianpu branch from 5abad5c to e579fd4 Compare April 19, 2017 04:44

byan61 force-pushed the 141581-jianpu branch from e579fd4 to c86dc39 Compare May 9, 2017 02:26

fix #141581: Jianpu linked staff display and saving to XML score file

f5bdc9b

byan61 force-pushed the 141581-jianpu branch from 422f53e to f5bdc9b Compare May 19, 2017 14:37

ericfont mentioned this pull request Apr 5, 2018

Hi what is your status on this? sirsoweird/jianpu-plugin#2

Closed

lasconic closed this Apr 6, 2018

ericfont mentioned this pull request Apr 6, 2018

fix #141581: Jianpu linked staff display and saving to XML score file #3614

Closed

141581 jianpu #2957

141581 jianpu #2957

Conversation

byan61 commented Jan 8, 2017

lasconic commented Jan 8, 2017 • edited Loading

byan61 commented Jan 8, 2017

byan61 commented Jan 9, 2017

lasconic commented Jan 9, 2017

byan61 commented Jan 9, 2017

lasconic commented Jan 9, 2017

lasconic commented Jan 9, 2017

Jojo-Schmitz commented Jan 9, 2017 • edited Loading

Jojo-Schmitz Jan 9, 2017 • edited Loading

Choose a reason for hiding this comment

Jojo-Schmitz Jan 9, 2017 • edited Loading

Choose a reason for hiding this comment

Jojo-Schmitz Jan 9, 2017 • edited Loading

Choose a reason for hiding this comment

byan61 commented Jan 10, 2017

Jojo-Schmitz commented Jan 10, 2017 • edited Loading

byan61 commented Jan 11, 2017

byan61 commented Jan 16, 2017

Jojo-Schmitz commented Feb 1, 2017

lasconic commented Feb 5, 2017

byan61 commented Feb 6, 2017

byan61 commented Feb 6, 2017

lasconic commented Feb 6, 2017

byan61 commented Feb 14, 2017

byan61 commented Apr 19, 2017

byan61 commented Apr 21, 2017

lasconic commented Apr 21, 2017

byan61 commented May 19, 2017

byan61 commented May 24, 2017

Jojo-Schmitz commented May 24, 2017

byan61 commented Jun 23, 2017

sirsoweird commented Dec 30, 2017

sirsoweird commented Jan 12, 2018

lasconic commented Jan 12, 2018

sirsoweird commented Jan 18, 2018

lasconic commented Jan 18, 2018

dannysalim commented Mar 12, 2018

lasconic commented Apr 6, 2018

odhot commented Dec 31, 2018

odhot commented Dec 31, 2018

Jojo-Schmitz commented Dec 31, 2018

Buronan13 commented Jan 22, 2019

David-C0pperfield commented Feb 28, 2020

Jojo-Schmitz commented Feb 28, 2020

sherlockholmestech commented Apr 16, 2020

odhot commented Apr 16, 2020

Thethnan commented Oct 13, 2020

Thethnan commented Oct 13, 2020

Jojo-Schmitz commented Oct 13, 2020

oorfeo commented Sep 2, 2021

Jojo-Schmitz commented Sep 2, 2021 • edited Loading

oorfeo commented Sep 2, 2021 via email

lasconic commented Jan 8, 2017 •

edited

Loading

Jojo-Schmitz commented Jan 9, 2017 •

edited

Loading

Jojo-Schmitz Jan 9, 2017 •

edited

Loading

Jojo-Schmitz Jan 9, 2017 •

edited

Loading

Jojo-Schmitz Jan 9, 2017 •

edited

Loading

Jojo-Schmitz commented Jan 10, 2017 •

edited

Loading

Jojo-Schmitz commented Sep 2, 2021 •

edited

Loading