fix #141581: Jianpu linked staff display and saving to XML score file #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfont
commented
Apr 6, 2018
| nnote = fac->cloneNote(onote, link); | ||
| else | ||
| nnote = new Note(*onote, link); | ||
| add(nnote); |
There was a problem hiding this comment.
That is also unusual because that JianpuChord class inherits from regular Chord anyway, so that already accounts for one copy of each note of the chord. But then this code adds the notes again, which seems redundant.
Closed
|
I'm not surprised this broke a lot of tests. There were quite a few changes made in the past year. |
dmitrio95
added
the
archived
|
Needs actualization for current master. |
|
Hey @dmitrio95 what was the conclusion for this PR? Will it be implemented? |
|
This PR had a lot of conflicts with the current state of MuseScore code and needs a relatively large amount of work to make it possible to merge it. That's why I archived it, I didn't mean to make any conclusion regarding its implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase byan61's Jianpu PR #2957 from May last year. I had to resolve a few conflicts and made a few small changes just to make it compile and run. I'm simply posting it here so others can look at the design and think about ways it might be redesigned or improved upon.