Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix #141581: Jianpu linked staff display and saving to XML score file #3614
This is a rebase byan61's Jianpu PR #2957 from May last year. I had to resolve a few conflicts and made a few small changes just to make it compile and run. I'm simply posting it here so others can look at the design and think about ways it might be redesigned or improved upon.
I don't like the fact that chord.cpp has been modified.
The added lines above are very strange because it causes a doubling of notes in the original chord such that in the new jianpu chord there are two new note elements (one regular note and one new jianpu note) for every note in the original. So in the resulting jianpu staff, I see and can select these two elements, when really there should only be one jianpu element (without a regular note):
I don't know why the code is doing this additional note cloning.