Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #267721, fix #268624: barline inspector - change span presets and reset span values on multiselection #3406

Merged
merged 1 commit into from
Feb 16, 2018
Merged

fix #267721, fix #268624: barline inspector - change span presets and reset span values on multiselection #3406

merged 1 commit into from
Feb 16, 2018

Conversation

lyrischesich
Copy link
Contributor

No description provided.

…on preset click, changes resetClicked() to simply call valueChanged with second parameter (reset) =true
@@ -377,23 +384,7 @@ void InspectorBase::valueChanged(int idx, bool reset)

void InspectorBase::resetClicked(int i)
{
Element* e = inspector->element();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wschweer That's a lot of code that you wrote removed here. Could you review this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wschweer reviewed "looks ok but i am just wondering if there is a better method to handle multiple selections..."
I'll merge.

@lasconic lasconic merged commit 98b6514 into musescore:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants