Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #273660: MIDI Keyboard not responding when pressed before opening a score #3769

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Jun 28, 2018

Seems needed for master too

@anatoly-os
Copy link
Contributor

I don't understand the reason why @rtega changed this value to 1. There must be a reason or it was just changes for debugging. @rtega are you around? I would never remind code changes I did 4 years ago, but... Do you remember your 451909c and the reason why you used active=1? :)

@anatoly-os anatoly-os merged commit 7b344ed into musescore:2.3 Jun 28, 2018
@rtega
Copy link
Contributor

rtega commented Jun 28, 2018

Nope, not really. Looking at the code I guess that while playing with the code I first changed the active to 1 and then added the if on line 1789 which would prevent the active going below zero. I guess active could be zero.

@anatoly-os
Copy link
Contributor

@rtega thank you for your notes.

@Jojo-Schmitz
Copy link
Contributor Author

So this should make it into master too then, right?

@anatoly-os
Copy link
Contributor

Yep, I'll merge manually

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jun 28, 2018

it should git cherry-pick 0631528 cleanly

@lasconic
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants