Compilation under MSVC #3796

handrok · 2018-07-10T13:30:36Z

Continue of @afdeprado work. Fix some bugs which appear in runtime. To fix the bug with QString::tostdstring() I replace this function to Foo.toUtf8().constData().

Jojo-Schmitz · 2018-07-11T10:01:23Z

AppVeyor is happy, compilation on Travis too, mtest on Travis is not, see https://travis-ci.org/musescore/MuseScore/jobs/402578693#L5092 ff. which indicates that some changes you did need also be done in testutils.cpp, i.e. change from _loadScore to Score::loadScore()

anatoly-os · 2018-07-11T11:16:14Z

And rename loadScore() to some proper name.

Jojo-Schmitz · 2018-07-11T12:19:46Z

Hmm, like isScoreLoaded() or scoreLoaded(bool b)? There is another loadScore() in a different context (new score wizard), doing something entirely different (it loads a score, surprise ;-))

Jojo-Schmitz · 2018-07-11T15:38:34Z

libmscore/score.h

@@ -541,6 +542,8 @@ class Score : public QObject, public ScoreElement {
      Score(MasterScore*, const MStyle&);
      virtual ~Score();

+      static bool& isScoreLoaded() { return _loadScore; }


Not sure, but I think a getter (isScoreLoaded()) should go along with a setter (scoreLoaded(bool b=true)) and not be the same thing

It is not the getter, it is some kind of singleton. It is correct solution to prevent using extern global variables. It cannot be replaced with get/set methods, because static variables lives and visible in the method itself, not in any other scope.

Well, now I don't understand. Current implementation is based on get/set logic actually. I thought @handrok made the local static variable. @handrok, could you replace class-scope static variable with function-scope one? Otherwise you need to introduce getter and setter.

lasconic · 2018-07-11T16:32:49Z

thirdparty/ofqf/qoscserver.cpp

@@ -88,7 +88,7 @@ void QOscServer::readyRead()
        		            args += data[ i++ ];
                  i++; //move one byte more!
        			    if ( ! args.isEmpty() ) {
-        				        QList<QVariant> list;
+        				        QList<QVariant> list1;


Do we really really need to avoid "list" as a variable name. No other way ?

Hah :) I believe it is from @afdeprado's changes to avoid same variable names to prevent warnings. Btw, should be addressed in this PR, indeed.

anatoly-os · 2018-07-13T14:40:16Z

AppVeyor won't be happy, cause you implemented MuseScore connect in the code and didn't hide it under ENABLE_WEBKIT #ifdef. This has to be fixed tomorrow.

Jojo-Schmitz · 2018-08-02T09:22:59Z

rebase needed...

…ed to generate a valid Visual Studio 2017 solution and projects for MuseScore. In detail, changes are as follows: - Changed .gitignore to ignore VS-specific files and directories. - VS uses a global settings file for the CMake build process: CMakeSettings.json. This is a text file, which is conceptually equivalent to the Makefile used to invoke CMake through Make. This file might need to be changed on an individual user basis, if dependencies are not installed in default paths. - New cmake macros to copy files in build\CopyFilesMacros.cmake. The code is from https://cmake.org/pipermail/cmake/2009-March/027892.html - Pre-compiled headers: Visual Studio requires to create pre-compiled headers per-project (a general per-solution PCH file, although possible, is extremely problematic and not recommended). Therefore, the new macro vstudio_pch in CreatePrecompiledHeader.cmake was created to add the pre-compiled header creation step to an existing target (similar to what is done for XCode). The existing macro precompiled_header was modified to set the values for a group of variables. As part of this, the empty file all.cpp was added to the root of the source tree, as VS requires a source file to create pre-compiled headers (the header file alone can not be compiled). - all.h is not copied to binary dir for MSVC, as I could determine no need to do this. Because of this, and the differences in PCH handling, the pseudo-targets mops1 and mops2 are not created for MSVC. - Revised all steps conditional on toolchain, and added MSVC paths as needed. In many instances, the MSVC path is the same as the MINGW path, but not always. - The manual (genManual) target used the getopt() functionality defined in POSIX libraries, which is not available on Windows. An LGPL'd port of getopt() for Windows was added in manual\getopt. The original source is in GitHub: nanoporetech/getopt-win32, based on a CodeProject article: https://www.codeproject.com/KB/cpp/getopt4win.aspx?msg=3987371. The corresponding CMakeLists.txt file was modified to include this files when compiling with MSVC. - Changes in CMakeLists.txt files to create valid MSVC targets. The changes, always conditional on the MSVC toolchain, consist of: x Setting target properties for MSVC x Using all.h in source dir x Adding pre-compiled headers to target x Removing dependency from mops1 and mops2 Notes: - The INSTALL target has NOT BEEN UPDATED for MSVC.

This commit contains changes required for MuseScore to compile under MSVC with no errors. There are several general categories of problems that resulted in errors with the compilation. Main issues: - Variable Length Arrays (VLA). This is a non-standard extension to C++, supported by clang toolchains, but not by MSVC. The initial workaround is to use std::vector<> instead of VLAs, eventually (if needed) with the original variable pointing to the beginning of the allocated array. More efficient alternatives are possible if profiling shows any code using VLAs to be timing-critical. - Floating-point constants not suffixed with "f" are doubles by default; in some instances, this leads to narrowing conversion errors (in other instances, just warnings). - MSVC does not support "or"/"and"/"not" in lieu of "||"/"&&"/"!". Changed unconditionally to use standard C++ symbols. - MSVC does not support the "__builtin_unreachable()" compiler hint. A similar, albeit not exactly equal, alternative is "__assume(0)", which is MSVC-specific. - MSVC does not support ranges in case statements. Replaced with list of cases instead of range (non-conditionally) Detailed changes, with per-file comments: - all.h: opt-in to deprecated features, include <io.h> and <process.h> instead of POSIX <unistd.h>, undefine "STRING_NONE" and "small", which Microsoft defines as macros, which result in compilation errors. - effects/compressor/zita.cpp: eliminated narrowing conversion error by appending "f" to float constants. - fluid/voice.cpp: appended "f" to float constants to eliminate narrowing conversion errors/warnings - libmscore/beam.cpp: conditionally replaced VLA - libmscore/edit.cpp: conditionally replaced VLA - libmscore/element.cpp: appended "f" to float constant - libmscore/fret.cpp: changed or -> || - libmscore/layout.cpp: conditionally replaced VLA - libmscore/mscore.cpp: conditionally replaced "__builtin_unreachable()" with "__assume(0)" for MSVC - libmscore/scorefile.coo: use correct char representation conversion for MSVC - libmscore/stringdata.cpp: conditionally replaced VLA - libmscore/system.cpp: conditionally replaced VLA - libmscroe/text.cpp: replaced range in case statement. - manual/genManual.cpp: use getopt() replacement. - midi/midifile.cpp: conditionally replaced VLA. This does not use the default replacement. - mscore/bb.cpp: replaced range in case statement. - mscore/capella.cpp: conditionally replaced VLA. Changed and -> && - mscore/driver:cpp: preclude errors due to macro redefinitions. - mscore/editstyle.cpp: conditionally replaced "__builtin_unreachable()" with "__assume(0)" for MSVC - mscore/importgtp-gp6.cpp: conditionally replaced VLA. - mscore/instrwidget.cpp: conditionally replaced VLA. - mscore/jackaudio.cpp: conditionally replaced VLA. Preclude errors due to macro redefinitions. - mscore/jackweakapi.cpp: Preclude errors due to macro redefinitions. Replacement for __atribute__((constructor)) through static object construction for MSVC. Force use of LoadLibraryA instead of LoadLibrary. - mscore/mididriver.h: Changed not -> ! - mscore/musescore.cpp: Changed not -> !. Conditionally replaced VLA. - mscore/resourceManager.cpp: conditionally replaced VLA. - mscore/timeline.cpp: conditionally replaced VLA. - omr/omrpage.cpp: conditionally replaced VLA. - synthesizer/msynthesizer.cpp: replaced UNIX sleep(1) method with MSVC Sleep(1000) (equivalent, but in ms instead of seconds) - synthesizer/msynthsizer.h: appended "f" to float constant - thirdparty/poppler/config.h: set defines for MSVC to preclude the use of inexistent libraries. - thirdparty/poppler/poppler/poppler-config.h: set defines for MSVC to preclude the use of inexistent libraries. Eliminated #defines for fmin and fmax which where causing problems. - thirdparty/poppler/poppler/PSOutputDev.cc: added #include <algorithm> for std::min() and std::max(). Note this is required per-C++ standard. - thirdparty/portmidi/pm_win/pmwinmm.c: undefined UNICODE to use char-based library functions. - thirdparty/qzip/qzip.cpp: changed or -> || - thirdparty/rtf2html/rtf_keyword.h: file format changed from Apple to UNIX, as MSVC does not supported the former. (NOT error related, just improvement on previous commit; manual/getopt/README.md: added link to source article)

…MSVC with no warnings. This commit contains changes required for MuseScore to compile under MSVC with no warnings. MuseScore is being compiled with the /W4 setting (warning level 4), which is similar to -wall -wextra on clang. This generates lots of warnings on MSVC, mainly for non-standard constructs and for constructs which might be bugs or might lead to bugs. Most warnings are in the following categories: - Name hiding: a variable hides a variable with the same name on a larger scope (or a field, or a function parameter). This can easily lead to bugs, and it is a best practice to avoid hiding variable names (see recommendation ES.12 in the C++ Core Guidelines by Stroustrop & Sutter (http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-reuse : ES.12: Do not reuse names in nested scopes) - Narrowing conversion: a numeric conversion results in loss of significant digits (for example, double -> float). The general recommendation is to use a cast to indicate this is designed behaviour. - Unreachable code: in several instances, there is unreachable code. The unreachable code is commented out. - (Potentially) uninitialized local variable. Just initialized the vars. - foreach(,) -> for(:): this does not generate a warning per-se (only a few of these generate warnings due to name hiding), but changed in keeping with "MuseScore Coding Rules" (https://musescore.org/en/handbook/musescore-coding-rules#Loops), which tells explicitly "Use C++11's "for" instead of Qt's "foreach":" ... "If you happen to be fixing some code and see a "foreach", please change that loop into a "for"." Most changes are in the categories indicated above. The next listing shows detailed changes for files which are *not* of the aforementioned types. - all.h: Disable warning C4127 (conditional expression is constant - generated in Qt header file qvector.h) - awl/aslider.h: unreachable code. - awl/knob.cpp: name hiding - awl/mslider.cpp: name hiding - awl/slider.cpp: name hiding - bww2mxml/parser.cpp: name hiding - effects/compressor/compressor.cpp: narrowing conversion - effects/zita1/zitagui.cpp: name hiding - fluid/fluid.cpp: foreach replacement. Name hiding. - fluid/mod.cpp: name hiding. - fluid/sfont.cpp: foreach replacement. Name hiding. Initialize vars. - fluid/voice.cpp: Name hiding. - libmscore/accidental.cpp: Name hiding. - libmscore/ambitus.cpp: Initialize vars. - libmscore/barline.cpp: Name hiding. Unreachable code. - libmscore/beam.cpp: Name hiding. - libmscore/chordrest.cpp: Unreachable code. - libmscore/scorefile.cpp: Name hiding. - manual/genManual.cpp: Name hiding. foreach replacement. - midi/midifile.cpp: Name hiding. Unreachable code. - omr/importpdf.cpp: Name hiding. foreach replacement. - omr/omr.cpp: Name hiding. foreach replacement. - omr/omrpage.cpp: Name hiding. foreach replacement. - omr/omrview.cpp: Name hiding. foreach replacement. - synthesizer/event.cpp: Unreachable code. - zerberus\channel.cpp: Narrowing conversion. - zerberus\instrument.cpp: Name hiding. - zerberus\sfz.cpp: Name hiding. - zerberus\voice.h: Suppress warning C4201: "nonstandard extension used: nameless struct/union" - zerberus\zerberus.cpp: Name hiding. Unreferenced parameter. - zerberus\zerberusgui.cpp: Name hiding.

…under MSVC with no warnings. This commit contains changes to third-party code required to compile under MSVC with no warnings. The changes in this commit are only for files in third-party code, which might be better to leave untouched for the time being. MuseScore is being compiled with the /W4 setting (warning level 4), which is similar to -wall -wextra on clang. This generates lots of warnings on MSVC, mainly for non-standard constructs and for constructs which might be bugs or might lead to bugs. Most warnings are in the following categories: - Name hiding: a variable hides a variable with the same name on a larger scope (or a field, or a function parameter). This can easily lead to bugs, and it is a best practice to avoid hiding variable names (see recommendation ES.12 in the C++ Core Guidelines by Stroustrop & Sutter (http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-reuse : ES.12: Do not reuse names in nested scopes) - Narrowing conversion: a numeric conversion results in loss of significant digits (for example, double -> float). The general recommendation is to use a cast to indicate this is designed behaviour. - Unreachable code: in several instances, there is unreachable code. The unreachable code is commented out. - (Potentially) uninitialized local variable. Just initialized the vars. - foreach(,) -> for(:): this does not generate a warning per-se (only a few of these generate warnings due to name hiding), but changed in keeping with "MuseScore Coding Rules" (https://musescore.org/en/handbook/musescore-coding-rules#Loops), which tells explicitly "Use C++11's "for" instead of Qt's "foreach":" ... "If you happen to be fixing some code and see a "foreach", please change that loop into a "for"." Most changes are in the categories indicated above. The next listing shows detailed changes for files which are *not* of the aforementioned types. - thirdparty/diff/diff_match_patch.cpp: foreach replacement. Unreachable code. - thirdparty/freetype/src/base/ftobjs.c: Unreachable code. - thirdparty/freetype/src/base/ftoutln.c: Initialize vars. - thirdparty/freetype/src/truetype/ttgload.c: Initialize vars. - thirdparty/kQOAuth/kqoauthrequest.cpp: Unreachable code. - thirdparty\ofqf\qoscserver.cpp: Name hiding. - thirdparty\portmidi\pm_common\portmidi.c: Name hiding. Unreferenced parameters. - thirdparty\portmidi\pm_win\pmwin.c: Unreachable code. - thirdparty\portmidi\pm_win\pmwinmm.c: Unreferenced locals. Unreferenced parameters. Assignment within conditional. - thirdparty\portmidi\porttime\porttime.c: Suppress warning C4206: "nonstandard extension used: translation unit is empty" - thirdparty\portmidi\porttime\ptwinmm.c: Unreferenced parameters. - thirdparty\qzip\qzip.cpp: Name hiding. - thirdparty\rtf2html\rtf2html.cpp: Name hiding.

1) fix some bugs which appear in runtime: replace QString::tostdstring() to Foo.toUtf8().constData(). 2) Enable start center online community. To use it you need download webengine in your QT lib. see instruction https://musescore.org/en/handbook/developers-handbook/compilation/compile-instructions-windows-visual-studio-2017-wip 3) update install steps. Add additional dlls for webEngine. Add copying dlls and musescore.exe to /msvc.install/bin folder. Run project will work with the "$(ProjectDir)\..\..\msvc.install\bin\MuseScore.exe" specified in Debugging field in mscore project 4) Moving AppVeyor from MinGW to MSVC. Exclude ALL MSVC project from INSTALL project. Exclude ALL from PACKAGE. Remove migw-cmake in script build, add .bat instead. Remove xcopy from 7z archive step 5) Fix warning : Warning C4703 potentially uninitialized local pointer variable '' used; Warning C4456 declaration of '' hides previous local declaration; Warning C4458 declaration of '' hides class member 6) Change path to 11 version wix toolset which created .msi installer package

handrok mentioned this pull request Jul 10, 2018

Visualstudio2017 #3795

Closed

Jojo-Schmitz mentioned this pull request Jul 10, 2018

271135 visual studio2017port #3645

Closed

handrok force-pushed the MSVC-Compilation branch from 6fa8db7 to 81f40b4 Compare July 11, 2018 09:31

anatoly-os mentioned this pull request Jul 11, 2018

Rebasing of @afdeprado's changes for MSVC excluding warnings fixes #3800

Closed

anatoly-os added the work in progress not finished work or not addressed review label Jul 11, 2018

anatoly-os assigned handrok Jul 11, 2018

handrok force-pushed the MSVC-Compilation branch 2 times, most recently from 7b7ad22 to 0191c2f Compare July 11, 2018 14:31

Jojo-Schmitz reviewed Jul 11, 2018

View reviewed changes

lasconic reviewed Jul 11, 2018

View reviewed changes

handrok force-pushed the MSVC-Compilation branch 2 times, most recently from 2e804ff to 7ce7f3f Compare July 13, 2018 14:33

handrok force-pushed the MSVC-Compilation branch 14 times, most recently from 40f064b to cdd452b Compare July 18, 2018 11:01

handrok force-pushed the MSVC-Compilation branch 18 times, most recently from d1cd04f to 0617940 Compare August 2, 2018 06:46

afdeprado added 4 commits August 3, 2018 09:15

handrok force-pushed the MSVC-Compilation branch 3 times, most recently from f2c12a5 to 0b3f468 Compare August 4, 2018 10:00

handrok force-pushed the MSVC-Compilation branch from 0b3f468 to df114f1 Compare August 4, 2018 10:17

anatoly-os merged commit e98043a into musescore:master Aug 4, 2018

anatoly-os removed the work in progress not finished work or not addressed review label Aug 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compilation under MSVC #3796

Compilation under MSVC #3796

handrok commented Jul 10, 2018 •

edited

Loading

Jojo-Schmitz commented Jul 11, 2018 •

edited

Loading

anatoly-os commented Jul 11, 2018

Jojo-Schmitz commented Jul 11, 2018

Jojo-Schmitz Jul 11, 2018 •

edited

Loading

anatoly-os Jul 11, 2018

Jojo-Schmitz Jul 11, 2018

anatoly-os Jul 11, 2018

Jojo-Schmitz Jul 11, 2018

lasconic Jul 11, 2018

anatoly-os Jul 11, 2018 •

edited

Loading

anatoly-os commented Jul 13, 2018

Jojo-Schmitz commented Aug 2, 2018

Compilation under MSVC #3796

Compilation under MSVC #3796

Conversation

handrok commented Jul 10, 2018 • edited Loading

Jojo-Schmitz commented Jul 11, 2018 • edited Loading

anatoly-os commented Jul 11, 2018

Jojo-Schmitz commented Jul 11, 2018

Jojo-Schmitz Jul 11, 2018 • edited Loading

Choose a reason for hiding this comment

anatoly-os Jul 11, 2018

Choose a reason for hiding this comment

Jojo-Schmitz Jul 11, 2018

Choose a reason for hiding this comment

anatoly-os Jul 11, 2018

Choose a reason for hiding this comment

Jojo-Schmitz Jul 11, 2018

Choose a reason for hiding this comment

lasconic Jul 11, 2018

Choose a reason for hiding this comment

anatoly-os Jul 11, 2018 • edited Loading

Choose a reason for hiding this comment

anatoly-os commented Jul 13, 2018

Jojo-Schmitz commented Aug 2, 2018

handrok commented Jul 10, 2018 •

edited

Loading

Jojo-Schmitz commented Jul 11, 2018 •

edited

Loading

Jojo-Schmitz Jul 11, 2018 •

edited

Loading

anatoly-os Jul 11, 2018 •

edited

Loading