fix #274432 regroup rhythms does not work if the expected notes are s… #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…horter than the initial notes
|
When applying the patch to master, the added test fails due to bug https://musescore.org/en/node/270433 I chose not to make regroup rhythm mess with tuplets on purpose (paste function also has limitations with tuplets). |
|
@AntonioBL thank you for the fix. I saw it once you'd pushed it, but didn't have time to react. Number of strings you changed here scares me personally. But after thorough reviewing, I see you mainly changed the code blocks position in the file. Is it possible to fix the issue with less changes in code? What was the actual changes that fix the issue? |
anatoly-os
added a commit
to anatoly-os/MuseScore
that referenced
this pull request
Jul 30, 2018
The code changes looks too big, but in fact it looks like removing ticks checks fixes the related issue.
anatoly-os
added a commit
that referenced
this pull request
Jul 30, 2018
Reapplied code from PR #3819. See #3837 (comment) to clarify the reason of `if (true)` statement.
|
See #3837. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…horter than the initial notes