fix #274902 #274925: Incorrect chord symbol position #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent excess layout of Harmony when switch to editing element.
handrok
changed the title
anatoly-os
reviewed
Sep 3, 2018
| @@ -707,6 +708,8 @@ void Harmony::startEdit(EditData& ed) | |||
| { | |||
| if (!textList.empty()) | |||
| setXmlText(harmonyName()); | |||
|
|
|||
| layoutInvalid = false; | |||
There was a problem hiding this comment.
I miss the place where we set layoutInvalid to true. Constructor is not taken into account.
There was a problem hiding this comment.
setXmlText() set layoutInvalid to true
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 14, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 17, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 17, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 17, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 17, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 17, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 18, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 19, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 21, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 21, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Sep 21, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Oct 27, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914
handrok
added a commit
to handrok/MuseScore
that referenced
this pull request
Nov 10, 2018
Add correect placement for _layout field in Harmony class Make layoutInvalid private as it was before musescore#3914 rebase after master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent excess layout of Harmony when switch to editing element.