fix #109661: pageSettings are not applied to excerpts #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neGjodsbol could you please review? I tested a bit and it worked properly. |
|
Still not working correctly because even cloning the Score* leads to rebuilding main score on fly. Keep investigating... |
Add Score::clone() Add std::uniques_ptr usage to prevent potential memory on the cloned Score*
anatoly-os
force-pushed
the
pagesettings_fix
branch
from
5718b7d
to
728f7e3
Compare
|
Should be OK now. @neGjodsbol please review. You can checkout this branch locally and compile the code to test. If you are on Windows, you can download the build from AppVeyor (click "Details" to the left of green build above and go to "Artifacts" tab there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/109661.
Fixed potential memory leak by putting cloned Score pointer to a unique_ptr.
This PR includes the best approaches from #3948, #3944, #3986 and #4019.