Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #281175: Removing rests attached to slurs in a voice >1 causes a crash #4534

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Jan 4, 2019

fixes the symtom, the crash, and the cause, the orphaned slur, which gets removed now.
2nd part courtesy to @mattmcclinch

Still I guess it should go together with #4522, which fixes another related issue by removing an orphaned slur.

@mattmcclinch
Copy link
Contributor

#4522 only removes slurs that were orphaned as a result of the implode function. There are other ways to orphan a slur, as described in https://musescore.org/en/node/281175.

@mattmcclinch
Copy link
Contributor

This fixes the cause, in the case described in issue 281175: mattmcclinch@51eee8d.

@Jojo-Schmitz
Copy link
Contributor Author

So do we need this instead of or in addition to mine?

@mattmcclinch
Copy link
Contributor

In general, it is a good idea to check for nullptr before dereferencing a pointer. Besides, there may still be other ways to orphan a slur.

@ericfont
Copy link
Contributor

ericfont commented Jan 4, 2019

Yes, both PRs should be accepted, as there almost surely are other ways which might produce orphaned slurs, such as: https://musescore.org/en/node/281083 "Slur should be deleted when changing duration of note deletes subsequent notes connected to the slur" which needs to be solved too.

…crash

fixes the symtom, the crash, and the cause, the orphaned slur,
which gets removed now.
@anatoly-os anatoly-os merged commit c73b148 into musescore:master Jan 8, 2019
@Jojo-Schmitz Jojo-Schmitz deleted the slur-rest-crash branch January 8, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants