Inspector facelift #4559
Inspector facelift #4559
Conversation
IsaacWeiss
force-pushed
the
inspector-tweaks
branch
from
d9acb07
to
a971fbd
Compare
|
Sample before and after comparison (both at minimum width): |
|
Also, when absurdly widened: |
|
Still WIP? |
|
Yes, a bunch more UI files to do (some have been done but not pushed), but now I know pretty much how to get what I want. Any target date to get into the next release? |
|
Next update is about in a week... |
|
@IsaacWeiss Hi. This PR is still in WIP state, but Musescore users will be very happy to see this PR merged :) |
anatoly-os
added
work in progress
|
rebase needed... |
|
Next week (Monday) I'm on it. |
IsaacWeiss
force-pushed
the
inspector-tweaks
branch
2 times, most recently
from
745eac1
to
7f8769d
Compare
IsaacWeiss
force-pushed
the
inspector-tweaks
branch
from
7f8769d
to
1f0abc5
Compare
|
All done. Another pass to fix tab order should happen at some point, but all the visual improvements are done. I should mention that I have added automatically hiding or disabling (which one generally depends on how much of a need there was to save space) certain options that depend on other options being enabled, and also that inspector_tuplet.ui was so messed up I'm surprised it wasn't noticed before. |
|
The big increase in number of lines is because, in choosing what to allow to stretch and what not to, I consistently had to change the parameters of certain elements from their default (and thus unwritten) settings. |
|
Regardless, WIP label can be removed and I consider this ready to merge. |
anatoly-os
removed
the
work in progress
|
Currently doing that pass for tab order. Limitation seems to be that the custom widgets are skipped, but that's the case in the current release as well, so I'll leave that for somebody else. |
|
Done |
|
Wonderful, the tab order issue has been bugging me to no end! Meanwhile, there is also #4672 which will likely conflict with this, but to me this current PR is far more important to get in first. |
|
@anatoly-os any desire for the tab order commit to be squashed with the rest? |
|
@IsaacWeiss no, it's ok. Leaving unrelated changes in different commits is a good thing to do. |
|
@IsaacWeiss thank you for the amazing work you did! The changes are great and we are one step closer to the better interface design :) |
|
Hmm, the Text Inspector became wider than before, the Note Inspector higher, neither for good reasons IMHO, width being more of an issue than hight I believe |
|
I always set my Inspector to not need scrollbars for the widest element (why can't we figure this out by default, BTW?), so the increase in width for the text is a serious regression to me. What confuses me is the image in the first comment shows the text inspector getting narrower, as I would have hoped. So I wonder what happened? |
I'm guessing that's because #4739 kept the "Follow staff size" (then "Size follows 'staff space' setting") checkbox on a separate row, and I moved it up a row (with the deletion of the "Font face" label) to be more compact vertically.
This should not be the case. Vertical spacing was slightly increased, but (1) the "Line" field was moved to be on the same row as "Fix to line", (2) three rows now disappear when "Play" is unchecked, and (3) the Chord Inspector (which is also present) is definitely less tall. |
|
Ah, I see, the eight "Select" buttons are farther away. I'll check into it. |
|
Got it, a spacer's sizeHint was lost. |
|
Exactly. And the Text inspector seems to have become wider because of the bold/italic/underline being in front of the align buttons |
Ah, probably. It's still better than before, though, and without labels it's guaranteed not to get worse in translation. I don't like the big waste of empty space if they're placed vertically, as in the original screenshot (imagine without the "Font style:" label)... |
|
Maybe I'm missing something, but wider = worse to me, nothing else actually matters nearly as much. There must be a way to get the best of both? |
|
@MarcSabatella No, IMHO you're right, width is way more important than height, and the text inspector needed to become narrower again, at least as narrow as it was before the change, definitly not wider, like it is now |
|
Regarding the Text Inspector width, I figured out a reasonable solution, which I'll make a PR for later. |
|
#4835 allows the Text Inspector to become narrower again. |
Various adjustments to alignment and spacing (in many cases to allow for greater compactness), along with some changes to appearance of buttons and horizontal lines, and working on adding more automatic showing/hiding of options based on what other options are checked.