Fix #289006: Expose "Select Instrument" in Inspector for Instrument Change text

[IsaacWeiss]

Addresses problem raised by Tantacrul in https://youtu.be/4hZxo96x48A?t=1149

[MarcSabatella]

Nice! I should point out I also have a related complementary PR #4958, to allow staff name changes via Staff Properties. If/when that gets merged, we could consider adding a staff Properties button here too. Another possibility is just add instrument names fields to the Inspector, but that might require a little more hook up. @joshwd36 this is the kind of thing your project is about, right? Any ideas on what might makes sense as a short term solution?

[IsaacWeiss]

Hmm, how about "Staff Properties..." and "Measure Properties..." buttons both being present whenever any note, rest, or range is selected (just like how they're in the menu when right-clicking on any note, rest, or empty space in a staff)?

When more than one staff or measure is in the range, the dialog could simply open to the first one.

[IsaacWeiss]

That's for another PR, though.

[IsaacWeiss]

Heyyyy, what if those buttons went in the status bar? 😲

[joshwd36]

@MarcSabatella, yes, this is the kind of thing that my GSoC project is looking to fix. My idea was to have the instrument change dialog come up when the object is added, and also have a button in the inspector (and possibly the right click menu too). This would then change the staff properties automatically.

[Harmoniker1]

The function name selectInstrument() is not very clear, if you don't know it's related to instrument change. Maybe something like selectNewInstrument() or simply changeInstrument() is better?

[IsaacWeiss]

I think it should match the title of the dialog it opens, but that also could be "Change Instrument."

[IsaacWeiss]

Actually, SelectInstrument is also the internal name of the object. I'm inclined to keep it that way.

[IsaacWeiss]

Updated and rebased

[Jojo-Schmitz]

another rebase needed

[dmitrio95]

This is partially included in #5782, and the inspector is being under a redesign now. Wouldn't it be better to wait for a redesign to happen in this case?