Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC 2019] Instrument change improvements #5782

Merged

Conversation

dmitrio95
Copy link
Contributor

This pull request contains changes from #5128, rebased to current master and adapted to work correctly with undoing/redoing actions. The following features from #5128 are not included to this PR:

  • Inspector changes, as a more complex Inspector redesign is going to happen soon;
  • Instrument change warnings, as this feature has certain issues which make it not suitable for merging at the moment;
  • Staff type changes from normal to percussion staff, as this feature seems to have been tested less extensively, and it is unclear whether it should actually belong to instrument change implementation (with the current paradigm StaffTypeChange elements should probably serve this purpose better);
  • Tests: some tests still need to be added, but tests from [WIP] Instrument change improvements #5128 cannot be reused directly since they assume the presence of "instrument change warning" feature.

The changes from this pull request might be adjusted in the future but still provide some initial version of what could potentially be merged to master regarding that feature before the next releases.

@dmitrio95 dmitrio95 added the work in progress not finished work or not addressed review label Mar 3, 2020
@dmitrio95 dmitrio95 added the strings Affects translatable strings label Mar 5, 2020
@dmitrio95 dmitrio95 force-pushed the joshwd36-instrument-change-improvements branch from 1232f69 to 3130bcd Compare March 18, 2020 16:27
@dmitrio95 dmitrio95 removed the work in progress not finished work or not addressed review label Mar 19, 2020
@anatoly-os anatoly-os merged commit 1137e60 into musescore:master Mar 19, 2020
@dmitrio95 dmitrio95 deleted the joshwd36-instrument-change-improvements branch March 19, 2020 11:54
@MarcSabatella
Copy link
Contributor

MarcSabatella commented Mar 19, 2020

Looking forward to checking this out! FWIW, it's introduced a warning, an unused variable "seg" in Score::deleteItem()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants