Fix QML palettes on Windows #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,7 @@ | |||
|
|
|||
| #include "palette/palettetree.h" | |||
| #include "palette/palettewidget.h" | |||
| #include "qml/msqmlengine.h" | |||
There was a problem hiding this comment.
needs an #ifdef Q_OS_WIN or some such
| @@ -297,6 +298,7 @@ class MuseScore : public QMainWindow, public MuseScoreCore { | |||
| PluginManager* pluginManager { 0 }; | |||
| QmlPluginEngine* _qmlEngine { 0 }; | |||
| #endif | |||
| MsQmlEngine* _qmlUiEngine { 0 }; | |||
dmitrio95
force-pushed
the
qml-palettes-windows-fix
branch
from
1ee8a8c
to
b00aafc
Compare
anatoly-os
added a commit
that referenced
this pull request
Aug 31, 2019
Fix QML palettes on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #5289 which resulted in palettes being not displayed in Windows builds.