fix #294076: Add Carillon instrument #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Carillon is before timpani? |
Jojo-Schmitz
force-pushed
the
carillion
branch
2 times, most recently
from
a1f994b
to
a07e68d
Compare
Jojo-Schmitz
changed the title
|
Does the order matter? And C is before T in the alphabeth |
|
I'm afraid I haven't seen an exception of any pitched percussion written before timpani on an orchestral score... so shouldn't the order in MuseScore be the same? |
|
I'd be surprised to see a carillon in any orchestral score, it is pretty much a solo instrument, check https://en.wikipedia.org/wiki/Carillon to see why ;-) |
|
I can of course move it elsewhere, like to the end of pitched percussions, after Alto Kalimba. |
Jojo-Schmitz
force-pushed
the
carillion
branch
from
a07e68d
to
aa398f7
Compare
|
As this adds strings for translation, it should get merged before string freeze |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.