fix #281866: fix inability to correctly set loop markers in parts #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As playback is currently always performed for MasterScore, it would be logical to store the information about positions of playback cursor and loop markers in MasterScore rather than individual excerpt scores. This commit implements this approach and fixes the issue with inability to set loop markers from parts. Strictly speaking, only changing Seq::setLoopSelection is absolutely necessary to fix the issue, the approach with moving _pos to MasterScore allows to naturally avoid incorrect visual feedback due to markers positions information being not synchronized across scores and ScoreViews.
|
I don't know if the code overlaps or not, but see also https://musescore.org/en/node/148311, which was an issue in 2.3.2 as well and the personal pet peeve of an associate of mine. |
|
So this does fix that other issue? Sorry if it wasn't clear, I wasn't suggesting I had tested that. |
|
No, the other issue is not related to the one fixed by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/281866.
As playback is currently always performed for MasterScore, it would be logical to store the information about positions of playback cursor and loop markers in MasterScore rather than individual excerpt scores. This commit implements this approach and fixes the issue with inability to set loop markers from parts. Strictly speaking, only changing
Seq::setLoopSelectionis absolutely necessary to fix the issue, the approach with moving_postoMasterScoreallows to naturally avoid incorrect visual feedback due to markers positions information being not synchronized across scores and ScoreViews.