fix #292343: measure numbers restart from 1 after section break even if the corresponding property got disabled #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmoniker1
changed the title
Why not to use |
Ouch! Guess I really need to study the code more carefully :o |
Harmoniker1
force-pushed
the
section-break
branch
from
316c1c0
to
295d370
Compare
Harmoniker1
changed the title
…if the corresponding property got disabled Some calls of `sectionBreak()` should be changed to `sectionBreakElement()` so the property can be accessed by `sectionBreakElement()->startWithMeasureOne()`.
Harmoniker1
force-pushed
the
section-break
branch
from
295d370
to
9f1f540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/node/292343.
Some calls of
sectionBreak()should be changed tosectionBreakElement()so the property can be accessed bysectionBreakElement()->startWithMeasureOne().