Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use autoplace for notenames plugin's staff text #5467

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Nov 11, 2019

placing voice 2 and 4 below staff, 1 and 2 above, as before, but now using autoplace rather than fixed offsets.

Solves https://musescore.org/en/node/296788 and https://musescore.org/en/node/296916

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Nov 13, 2019

Well, I don't see any reason why this would need to wait for 3.4?
I don't see any urgency either though, i.e. no need for it to be in 3.3.1, but also no harm.

@dmitrio95
Copy link
Contributor

Maybe I misunderstood the purpose of this change then:
https://github.com/musescore/MuseScore/pull/5467/files#diff-fb15bc815be1546cdb92f42a00e4a6d8L21-R21

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Nov 13, 2019

Ah, yes, indeed, this is just a bump in the plugin's version number, no relation to the MuseScore version it'd run on. Not an important part of that PR at all, just cosmetic. Not anthing like those \since comments in the pulgin API code.
If you want then being in sync, just let me know and also tell which version it'd be merged into.
None of the other plugins' version numbers follow the MuseScore version number though.
@DLLarson might have had that in mind in his 26ab4f5 though

placing voice 2 and 4 below staff, 1 and 2 above, as before, but now
using autoplace rather than fixed offsets.
@dmitrio95 dmitrio95 removed this from the MuseScore 3.4 milestone Nov 14, 2019
@dmitrio95 dmitrio95 merged commit 9aaca19 into musescore:master Nov 15, 2019
@Jojo-Schmitz Jojo-Schmitz deleted the notenames branch November 15, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants