Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #299697: Repeat play a bar, goes back to first bar briefly #5684

Closed
wants to merge 1 commit into from

Conversation

jrpear
Copy link
Contributor

@jrpear jrpear commented Feb 9, 2020

Resolves: https://musescore.org/en/node/299697

Made cursor rewind earlier in loop play mode and changed rewind target from 0 to loopIn.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 9, 2020

Under which name did you sign the CLA?
I don't see any tests in this PR. Not sure any are needed, but you ticked that box.

@jrpear
Copy link
Contributor Author

jrpear commented Feb 9, 2020 via email

@ProbablyFaiz
Copy link

Looks good to me, fixed the bug on my machine

mscore/seq.cpp Outdated Show resolved Hide resolved
@anatoly-os
Copy link
Contributor

anatoly-os commented Apr 14, 2020

@jpear1 why do you make a PR from your account but use another person's branch (https://github.com/CCS-1L-F19)?

@jrpear
Copy link
Contributor Author

jrpear commented Apr 14, 2020

I was working on MuseScore as part of a class project and the professor asked that all of our repos be in the class organization so that he could easily track everyone's progress. I can submit another PR from my account there's worries about the CLA agreement.

@Jojo-Schmitz
Copy link
Contributor

Yes, better resubmit or rebase to come from your account

@jrpear
Copy link
Contributor Author

jrpear commented Apr 14, 2020

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants