-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #299697: Repeat play a bar, goes back to first bar briefly #5684
Conversation
Under which name did you sign the CLA? |
I signed under jpear1.
I didn't change any tests in this PR. I thought that checkbox was for verifying that I had run the existing tests on my changes. I set up my own copy of MuseScore on Travis and the tests passed on there.
…On Sat, Feb 8, 2020 at 10:59 PM Joachim Schmitz ***@***.***> wrote:
Under which name did you sign the CLA?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5684?email_source=notifications&email_token=AGKFIVEPB4VQME6JZRAEBILRB6STNA5CNFSM4KR6RFL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGEHMY#issuecomment-583812019>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGKFIVAX2AEJQZ4WSIN6EG3RB6STNANCNFSM4KR6RFLQ>
.
|
Looks good to me, fixed the bug on my machine |
@jpear1 why do you make a PR from your account but use another person's branch (https://github.com/CCS-1L-F19)? |
I was working on MuseScore as part of a class project and the professor asked that all of our repos be in the class organization so that he could easily track everyone's progress. I can submit another PR from my account there's worries about the CLA agreement. |
Yes, better resubmit or rebase to come from your account |
Done. |
Resolves: https://musescore.org/en/node/299697
Made cursor rewind earlier in loop play mode and changed rewind target from 0 to loopIn.