Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #302388 - Changing the order of the instruments (staves) #5824

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

njvdberg
Copy link
Contributor

Resolves: https://musescore.org/en/node/302388

Implementation is using another QTreeWidgetItem constructor which accepts the preceding item. This makes the implementation straight forward.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [n.a.] I created the test (mtest, vtest, script test) to verify the changes I made

Implementation is using another QTreeWidgetItem constructor which accepts the preceding
item. This makes the Implementation straight forward.
@dmitrio95 dmitrio95 merged commit 0f9d038 into musescore:master Mar 19, 2020
@njvdberg njvdberg deleted the issue-302388-instrument-widget branch March 27, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants