Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix related to #93376: Added smooth scrolling controls and preferences for continuous view #5898

Merged

Conversation

SKefalidis
Copy link
Contributor

@SKefalidis SKefalidis commented Apr 4, 2020

Resolves: https://musescore.org/en/node/93376

Added the ability to smoothly pan in continuous view, during playback (gif with terrible framerate below, in reality, it's smooth :^). For that to happen, a second 'control-cursor' is used. The view follows this cursor. The speed of the control-cursor is influenced by the distance between it and the playback-cursor and by the time elapsed between each update (tied to the heartbeat, every 20ms as of right now).

The variables used in the calculations have been added to the preferences. Some of them are hidden (and commented out, that way they can be easily enabled in the future), the rest is available in the advanced tab. If the users request more control over the behavior I have prepared a separate tab used to control all the variables (as shown in the images), but that has been removed from this PR.

ezgif com-crop

Alternative preferences, if that's required:
image
image

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@SKefalidis SKefalidis force-pushed the playback-smooth-less-options branch from 2700550 to b27c236 Compare April 4, 2020 15:59
@SKefalidis
Copy link
Contributor Author

SKefalidis commented Apr 4, 2020

Build errors

Should be ok now, uploaded the wrong thing.

@Jojo-Schmitz
Copy link
Contributor

rebase needed

@SKefalidis SKefalidis force-pushed the playback-smooth-less-options branch 2 times, most recently from 6014ab9 to b555995 Compare April 18, 2020 18:15
@SKefalidis
Copy link
Contributor Author

Rebase completed.

@SKefalidis
Copy link
Contributor Author

Fixed formatting and replaced QTimer with QElapsedTimer.

@anatoly-os anatoly-os merged commit cb469f0 into musescore:master Apr 29, 2020
@Ryzza5
Copy link

Ryzza5 commented May 9, 2020

The continuous scrolling feature is very welcome and well implemented. I think the following two points are missing, either as default behaviour or advanced settings:

  1. Keep scrolling at the end of the song. On a fast 130 BPM song, when the scrolling suddenly stops near the end of the song, it's surprisingly jarring, like jumping off a spinning ride and feeling a little dizzy. I would prefer to see the entire staves keep scrolling off the screen.

  2. Bar counter on the left - I would find this to be more useful it it showed the bar number where the floating cursor is, to reflect where I am, not where I was 2-3 bars ago. To a lesser extent the same could be said about the key & time signature, but since these don't change as often it's less of a concern for me.

I also observed that the smoothness took a considerable drop when the Timeline view was also enabled. I have an Intel i9 9900K and vVidia 1080 Ti so I don't know if anything can be done about this.

I hope the feedback is valuable.
Thanks :)

@SKefalidis
Copy link
Contributor Author

SKefalidis commented May 9, 2020

@Ryzza5 I will look into all of the issues/suggestions. Your feedback is very valuable :^)

side note: I believe that this should have been (and should be) posted at https://musescore.org/en/project/issues/musescore

@ronaldocpontes
Copy link

That's a great feature and I've seen it has been merged.

However, I can't find a way to use Continous Playback. I have version 3.2.54... on Mac but I can't find a way to enable the feature nor I see the settings on the preferences screen. How can I enable Continous Playback?

image
image

@MarcSabatella
Copy link
Contributor

See the Advanced tab of the preferenecs dialog.

For further questions on how to use MsueScore, please see the Support forum on musescore.org.

@ronaldocpontes
Copy link

Found it. Thanks @MarcSabatella

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants