Screen Reader status messages #6173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoogle
commented
Jun 6, 2020
|
Looking forward to trying this out! I'll try to get it going on Linux tomorrow, Windows Monday. I assume that's too late for 3.5 beta, but maybe not for the final release, or for 3.5.1 or whatever. |
Creates an 'accessibleMessage' string and demonstrates its use by providing a status message when switching to note input mode. The 'accessibleMessage' string is different to the pre-existing 'accessibleInfo' string that provides information about the selected element(s). Two strings are needed because changes to the 'info' string are calculated based on its previous value, hence this value must not be overwritten by other messages.
shoogle
force-pushed
the
rnib-text-editing
branch
2 times, most recently
from
0c7a4db
to
a946a2e
Compare
When navigating textual elements (e.g. staff text) with the cursor keys during editing, the screen reader will announce the name of the character or word to the right of the caret (text cursor). It also announces when characters are selected or deselected.
shoogle
force-pushed
the
rnib-text-editing
branch
from
a946a2e
to
97ec339
Compare
shoogle
changed the title
12 tasks
anatoly-os
added a commit
that referenced
this pull request
Jun 10, 2020
Screen Reader status messages
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 12, 2020
Fixes regression caused by commit 3960396 in PR musescore#6173.
7 tasks
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 12, 2020
Fixes regression caused by commit 3960396 in PR musescore#6173. The accessibleMessage string is cleared in the function AccessibleScoreView::text(), but that function only gets called if there is a screen reader running. If there is no screen reader then accessibleMessage would never be emptied after it was first set, hence currentInfoChanged() was never called to set the status bar text.
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 12, 2020
Also fixes an accessibility bug in commit 3960396 in PR musescore#6173 which caused the screen reader to say "note input mode" periodically rather than just once upon entering that mode. This was due to setModeText() being called with the same value as before.
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 12, 2020
Fixes regression caused by commit 3960396 in PR musescore#6173. The accessibleMessage string is cleared in the function AccessibleScoreView::text(), but that function only gets called if there is a screen reader running. If there is no screen reader then accessibleMessage would never be emptied after it was first set, hence currentInfoChanged() was never called to set the status bar text.
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 12, 2020
Also fixes an accessibility bug in commit 3960396 in PR musescore#6173 which caused the screen reader to say "note input mode" periodically rather than just once upon entering that mode. This was due to setModeText() being called with the same value as before.
1 task
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 15, 2020
Fixes an accessibility bug in commit 3960396 in PR musescore#6173 that caused the screen reader to say "note input mode" periodically rather than just once upon entering that mode. This interfered with the usual screen reader output for that mode. Also displays mode text for "Normal mode".
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 17, 2020
Fixes regression caused by commit 3960396 in PR musescore#6173. The accessibleMessage string is cleared in the function AccessibleScoreView::text(), but that function only gets called if there is a screen reader running. If there is no screen reader then accessibleMessage would never be emptied after it was first set, hence currentInfoChanged() was never called to set the status bar text.
shoogle
added a commit
to shoogle/MuseScore
that referenced
this pull request
Jun 17, 2020
Changes: - Display mode text for "Normal mode". - Avoid screen reader output on entering playback mode so that the screen reader does not talk over the music. Also fixes an accessibility bug in commit 3960396 in PR musescore#6173 that caused the screen reader to say "note input mode" periodically rather than just once upon entering that mode. This interfered with the usual screen reader output for that mode, as reported in #306726.
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Sends status messages to the screen reader to inform the user about actions such as:
Maybe it's a bit cheeky to add new features to 3.5 at this late stage, but this is a major win for accessibility and has zero impact on non-blind users.