Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #306878 Retain focus for non-modal dialogs #6245

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Jun 22, 2020

Resolves: https://musescore.org/en/node/306878

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

@shoogle shoogle marked this pull request as ready for review June 22, 2020 18:23
@anatoly-os anatoly-os merged commit 0e9ba0e into musescore:3.x Jun 22, 2020
@shoogle shoogle deleted the dialog-focus branch June 22, 2020 20:01
anatoly-os added a commit that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants