Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #307242: [MusicXML import] Musescore crashes when loading .mxl fi… #6269

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Jun 28, 2020

…le containing incomplete tuplet

Resolves: https://musescore.org/en/node/307242

Prevent crash on importing MusicXML file containing incomplete tuplet. Crash caused by missing nullptr check.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@anatoly-os anatoly-os merged commit b0d82ff into musescore:3.x Jul 7, 2020
anatoly-os added a commit that referenced this pull request Jul 7, 2020
fix #307242: [MusicXML import] Musescore crashes when loading .mxl fi…
@lvinken lvinken deleted the 307242-incomplete-tuplet-3.x branch September 21, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants