Crash during the initialization of start center, fix 275837 #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly is the target issue, #275837 or #278817? |
|
Both I guess But more importantly it needs to build first... I don't quite understand the fix though, as far as I can tell it fixes a hang if a firewall block access, but those issue report a crash? |
Jojo-Schmitz
reviewed
Sep 9, 2020
vpereverzev
force-pushed
the
start_up_crash
branch
from
ca8c89e
to
00a8f18
Compare
Jojo-Schmitz
approved these changes
Sep 11, 2020
|
@Jojo-Schmitz The things are tied here (hang and crash). I've managed to reproduce the crash. So when your internet connection is blocked you'll hang on and after some time(depends on OS environment) you might encounter a crash due to the uninitialized variable usage |
vpereverzev
force-pushed
the
start_up_crash
branch
from
00a8f18
to
fd25419
Compare
|
OK, thanks for clarifying |
vpereverzev
force-pushed
the
start_up_crash
branch
from
fd25419
to
6cb94f2
Compare
igorkorsukov
approved these changes
Sep 11, 2020
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/278817
If there is no internet connection or an editor is blocked by firewall then we'll hang on download extensions step because of QEventLoop::exec(). The problem is that we can quit from event loop only when QNetworkReply::finished() signal will be emited.