Fix #24409 : crash when creating a new SimpleText element or adidgin text to an empty one #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When some text is typed for a newly created SimpleText text item (staff, system, ...), the program crashes. Added a test to check the SimpleTex::_text list is not empty before adding to it.
|
Is this supposed to fix #24409? Just trying to connect the dots... |
|
Probably it fixes this too, but I just got a crash while adding a staff text and tried to fix it to go on working. If it useful, it is there. |
|
No, unfortunately it does not, I've just tried it. Nor does it fix the issue with system- and staff text, not for me at least |
|
Additionally changing line 564 of libmscore\simpletext.cpp back to |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jan 27, 2014
or staff- or system text. Using the change from PR musescore#666 and additionaly reverting one line back to what it was before commit 95bf389.
Adds another test for TLine::_text being empty or not.
wschweer
added a commit
that referenced
this pull request
Jan 28, 2014
Fix #24409 : crash when creating a new SimpleText element or adidgin text to an empty one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some text is typed for a newly created
SimpleTexttext item (staff, system, ...), the program crashes.SimpleText::_textlist is not empty before adding to it.TLine::_textlist is not empty before taking its y coord.