New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #24409: crash when adding lyrics #668

Closed

Jojo-Schmitz wants to merge 1 commit into musescore:master from Jojo-Schmitz:24409-crash-adding-lyrics-system-or-staff-text

Contributor

Jojo-Schmitz commented Jan 27, 2014

or staff- or system text.
Using the change from PR #666 and additionaly reverting one line back to
what it was before commit 95bf389.


          fix #24409: crash when adding lyrics

ded83a2

or staff- or system text.
Using the change from PR musescore#666 and additionaly reverting one line back to
what it was before commit 95bf389.

Contributor Author

Jojo-Schmitz commented Jan 27, 2014

Not sure at all whether this is the right thing to do, but the crash is solved at least ;-)

Contributor

mgavioli commented Jan 27, 2014

Rather than reverting a change which is probably connected with other improvements, I preferred to add another test to prevent the ASSERT condition behind line 564 to trigger if the textual element has no text (yet): see last version of #666

Contributor Author

Jojo-Schmitz commented Jan 28, 2014

Agreed. I wasn't sure about my fix at all, except that it solved the crash.

Jojo-Schmitz closed this

Jojo-Schmitz deleted the 24409-crash-adding-lyrics-system-or-staff-text branch

January 28, 2014 08:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment