Fix #313105: "No chord" MusicXML import #6888
Conversation
infojunkie
changed the title
| if (ee.hasAttribute("text")) { | ||
| QString rtext = ee.attribute("text"); | ||
| if (rtext == "") { | ||
| if (_e.attributes().hasAttribute("text")) { |
There was a problem hiding this comment.
I suppose this means if the kind tag appears before the root-step tag, and there is no "none" on the root-step, we end up setting the root tpc after all. That's probably a reasonable interpretation of a somewhat ambiguous spec anyhow.
There was a problem hiding this comment.
Thinking more about it, I would have preferred to only rely on kind=="none" to signal an invalid root, since that much is clear. Happy to play it however you see fit though.
There was a problem hiding this comment.
Anything more to do here on my side?
There was a problem hiding this comment.
Kind before root-step would not be a valid MusicXML file, the schema does not allow that.
The root-step element is a child of the root element, which must be before the kind element.
|
@lvinken Mind to have a look? |
|
Will have a look. |
|
Checked, looks fine to me. |
Resolves: https://musescore.org/en/node/313105
This fix imports a MusicXML
harmonyelement withkind=noneto signify a "no chord" (invalid root) on the MuseScore sheet as per forum discussion.