Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stem length of notes with mirrored notehead #7050

Merged

Conversation

cbjeukendrup
Copy link
Contributor

Resolves: https://trello.com/c/EpRJtt7w/51-square-caps-adds-gap-between-stem-and-notehead-when-notehead-is-reversed

Fixed by cleverly reading the anchor points for noteheads. (In contrast to what was suggested in the Trello issue, this was not related to replacing the round caps by flat ones, but became only more visible.)

Before:
Mirrored Noteheads before
After:
Mirrored Noteheads after
The issue with the ledger line being too long for that last note already existed in 3.5.2. I might solve that in another PR.

A (still pretty theoretical) use case for 'mirrored noteheads' could be, when one doesn't like how the notes are oriented in a chord. Or, when one wants to show on an educational worksheet: "This is wrong".
Mirrored Noteheads Use Case


  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@ecstrema
Copy link
Contributor

ecstrema commented Dec 8, 2020

does this also fix the x notehead issue?

@cbjeukendrup
Copy link
Contributor Author

@Marr11317 No, unfortunately not. I don't really see yet what is the cause of that problem...

@vpereverzev vpereverzev merged commit 5c92652 into musescore:3.x Dec 10, 2020
@cbjeukendrup cbjeukendrup deleted the mirrored-notehead-stem-length branch December 14, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants