Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] SMuFL Symbol Anchors, ledger lines, flag placing, Shadow Note refactoring #7316

Merged

Conversation

cbjeukendrup
Copy link
Contributor

  • Implement new way to get and set SMuFL Anchors for symbols
    There is a new enum for the currently supported anchors, and the anchors are now stored in a std::map.

  • Fix ledger line length for Chord and Ambitus
    That is:
    a) draw with FlatCaps instead of RoundCaps
    b) append the whole ledgerLineLength at both sides of the note, instead of half on each side.

  • Correctly handle note flag placing, respecting bbox
    A MU4 version for PR [MU3] Score symbols bounding boxes #6894

  • Shadow note refactoring
    In a way a MU4 version of PR Fix shadow note ledger lines and stem length #7064
    Give the Shadow Note more information and make better use of its inheritance from Element, so that is can be drawn much more 'realistically'.
    Also implements the corrections made to flag placement / stem height from the previous commit.

  • Fix stem length of notes with mirrored notehead
    A MU4 version for PR Fix stem length of notes with mirrored notehead #7050
    At least, the issue is fixed only after a re-layout is triggered. That could suggest two things:

    • It is broken in another place too (but very unclear where)
    • n->mirror() doesn't return the right value at first.
  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@igorkorsukov
Copy link
Contributor

igorkorsukov commented Feb 4, 2021

Please could you do rebase

And draw stem with FlatCap instead of RoundCap.
Give the Shadow Note more information and make better use of its inheritance from Element, so that is can be drawn much more 'realistically'.
Also implements the corrections made to flag placement / stem height from the previous commit.
At least, the issue is fixed only after a re-layout is triggered. That could suggest two things:
- It is broken in another place too (but very unclear where)
- n->mirror() doesn't return the right value at first.
@cbjeukendrup
Copy link
Contributor Author

Please could you do rebase

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants